Remove dead code from CPDF_InterForm.

Remove dead code from CPDF_InterForm.

Remove default arguments.

Committed: https://pdfium.googlesource.com/pdfium/+/7c292e0f67e0f0bf4062e0b2adf244e17d7dacb5

[Lei Zhang, 2016-09-28 18:52:38]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 18:52:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 19:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 19:04:55]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-28 19:07:25]

Description was changed from

==========
Remove dead code from CPDF_InterForm.
==========

to

==========
Remove dead code from CPDF_InterForm.

Remove default arguments.
==========

[Lei Zhang, 2016-09-28 19:07:25]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[Tom Sepez, 2016-09-28 20:21:06]

lgtm

https://codereview.chromium.org/2380753003/diff/1/core/fpdfdoc/include/cpdf_i...
File core/fpdfdoc/include/cpdf_interform.h (right):

https://codereview.chromium.org/2380753003/diff/1/core/fpdfdoc/include/cpdf_i...
core/fpdfdoc/include/cpdf_interform.h:52: size_t CountFields(const
CFX_WideString& csFieldName);
nit: const method (this and the next one)?

[Lei Zhang, 2016-09-28 20:40:57]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 20:41:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-28 20:42:40]

https://codereview.chromium.org/2380753003/diff/1/core/fpdfdoc/include/cpdf_i...
File core/fpdfdoc/include/cpdf_interform.h (right):

https://codereview.chromium.org/2380753003/diff/1/core/fpdfdoc/include/cpdf_i...
core/fpdfdoc/include/cpdf_interform.h:52: size_t CountFields(const
CFX_WideString& csFieldName);
On 2016/09/28 20:21:06, Tom Sepez wrote:
> nit: const method (this and the next one)?

Done, and a bit more.

[Tom Sepez, 2016-09-28 20:46:50]

++LGTM

https://codereview.chromium.org/2380753003/diff/20001/core/fpdfdoc/cpdf_inter...
File core/fpdfdoc/cpdf_interform.cpp (right):

https://codereview.chromium.org/2380753003/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:855: if (pField->CountControls() < 2)
nit: combine with 853

[commit-bot: I haz the power, 2016-09-28 20:56:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 20:56:32]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-28 21:02:40]

https://codereview.chromium.org/2380753003/diff/20001/core/fpdfdoc/cpdf_inter...
File core/fpdfdoc/cpdf_interform.cpp (right):

https://codereview.chromium.org/2380753003/diff/20001/core/fpdfdoc/cpdf_inter...
core/fpdfdoc/cpdf_interform.cpp:855: if (pField->CountControls() < 2)
On 2016/09/28 20:46:49, Tom Sepez wrote:
> nit: combine with 853

Done.

[Lei Zhang, 2016-09-28 21:02:43]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-09-28 21:02:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2380753003/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-09-28 21:02:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 21:14:28]

Description was changed from

==========
Remove dead code from CPDF_InterForm.

Remove default arguments.
==========

to

==========
Remove dead code from CPDF_InterForm.

Remove default arguments.

Committed:
https://pdfium.googlesource.com/pdfium/+/7c292e0f67e0f0bf4062e0b2adf244e17d7d...
==========

[commit-bot: I haz the power, 2016-09-28 21:14:29]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/7c292e0f67e0f0bf4062e0b2adf244e17d7d...