content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java - Issue 2380743003: Refactor ContentViewClient (2/6)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

Issue 2380743003: Refactor ContentViewClient (2/6) (Closed)

Patch Set: tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('K') | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/public/test/android/BUILD.gn » ('j') | content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

index 99fd06a34fee43719166b31700da526b0b145e7e..20d052501f4afbe1bca67ef5891ac3ca5451276c 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java

@@ -83,7 +83,8 @@ public class SelectPopupTest extends ContentShellTestBase {

CriteriaHelper.pollInstrumentationThread(new PopupHiddenCriteria());

final ContentViewCore viewCore = getContentViewCore();

- final TestCallbackHelperContainer viewClient = new TestCallbackHelperContainer(viewCore);

+ final TestCallbackHelperContainer viewClient = new TestCallbackHelperContainer(

+ getWindowAndroid(), viewCore);

final OnPageFinishedHelper onPageFinishedHelper = viewClient.getOnPageFinishedHelper();

// Once clicked, the popup should show up.