Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 2380743003: Refactor ContentViewClient (2/6) (Closed)
Patch Set: tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index 0f528187c68a4237afc2df7f91c0e021d28fac0c..b11336ddf33a723eef7c9ad121ca4dd6e4eccdda 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -4,14 +4,9 @@
package org.chromium.content.browser;
-import android.content.ActivityNotFoundException;
-import android.content.Context;
-import android.content.Intent;
import android.view.KeyEvent;
import android.view.View.MeasureSpec;
-import org.chromium.base.Log;
-
/**
* Main callback class used by ContentView.
*
@@ -80,84 +75,6 @@ public class ContentViewClient {
}
/**
- * Called when the contextual ActionBar is shown.
- */
- public void onContextualActionBarShown() {
- }
-
- /**
- * Called when the contextual ActionBar is hidden.
- */
- public void onContextualActionBarHidden() {
- }
-
- /**
- * Perform a search on {@code searchQuery}. This method is only called if
- * {@link #doesPerformWebSearch()} returns {@code true}.
- * @param searchQuery The string to search for.
- */
- public void performWebSearch(String searchQuery) {
- }
-
- /**
- * If this returns {@code true} contextual web search attempts will be forwarded to
- * {@link #performWebSearch(String)}.
- * @return {@code true} iff this {@link ContentViewClient} wants to consume web search queries
- * and override the default intent behavior.
- */
- public boolean doesPerformWebSearch() {
- return false;
- }
-
- /**
- * If this returns {@code true} the text processing intents should be forwarded to {@link
- * startProcessTextIntent(Intent)}, otherwise these intents should be sent by WindowAndroid by
- * default.
- * @return {@code true} iff this {@link ContentViewClient} wants to send the processing intents
- * and override the default intent behavior.
- */
- public boolean doesPerformProcessText() {
- return false;
- }
-
- /**
- * Send the intent to process the current selected text.
- */
- public void startProcessTextIntent(Intent intent) {}
-
- /**
- * @param actionModeItem the flag for the action mode item in question. See
- * {@link WebActionModeCallback.ActionHandler} for a list of valid action
- * mode item flags.
- * @return true if the action is allowed. Otherwise, the menu item
- * should be removed from the menu.
- */
- public boolean isSelectActionModeAllowed(int actionModeItem) {
- return true;
- }
-
- /**
- * Called when a new content intent is requested to be started.
- */
- public void onStartContentIntent(Context context, String intentUrl, boolean isMainFrame) {
- Intent intent;
- // Perform generic parsing of the URI to turn it into an Intent.
- try {
- intent = Intent.parseUri(intentUrl, Intent.URI_INTENT_SCHEME);
- intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
- } catch (Exception ex) {
- Log.w(TAG, "Bad URI %s", intentUrl, ex);
- return;
- }
-
- try {
- context.startActivity(intent);
- } catch (ActivityNotFoundException ex) {
- Log.w(TAG, "No application can handle %s", intentUrl);
- }
- }
-
- /**
* Check whether a key should be propagated to the embedder or not.
* We need to send almost every key to Blink. However:
* 1. We don't want to block the device on the renderer for

Powered by Google App Engine
This is Rietveld 408576698