Provide UI for per-extension enabling/disabling of error collection.

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js"></include>
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 130 matching lines @@
           var checked = e.target.checked;
           butterBarVisibility[extension.id] = checked;
           butterBar.hidden = !checked || extension.is_hosted_app;
           chrome.send('extensionSettingsEnableIncognito',
                       [extension.id, String(checked)]);
         });
       }
       var butterBar = node.querySelector('.butter-bar');
       butterBar.hidden = !butterBarVisibility[extension.id];
 
+      // The 'collect errors' checkbox. This should only be visible if the
+      // error console is enabled - we can detect this by the existence of the
+      // |errorCollectionEnabled| property.
+      var errorCollectionEnabled = extension.errorCollectionEnabled;
+      if (errorCollectionEnabled !== undefined) {

[not at google - send to devlin, 2014/04/16 21:28:31]

this seems a bit fragile, all it takes is a subtle change in the way that the
model is populated and we'll have an odd consequence. just pass down a flag
similar to how developer mode is passed through.

p.s. extension.hasOwnProperty('errorCollectionEnabled') would be a slightly
stronger check.

[Devlin, 2014/04/16 22:50:41]

Passed a flag, but, per in-person conversation, not like developer mode, because
adding classes to the whole page is not a good idea for this.

[not at google - send to devlin, 2014/04/16 23:22:07]

wantsErrorCollection vs errorCollectionEnabled sure is a fine line :)

[Devlin, 2014/04/16 23:58:22]

Yeah, chose it because it mirrors "wantsFileAccess" and "allowFileAccess", etc.

+        node.querySelector('.error-collection-control').hidden = false;
+        var errorCollection =
+            node.querySelector('.error-collection-control input');
+        errorCollection.checked = errorCollectionEnabled;
+        errorCollection.addEventListener('change', function(e) {
+          chrome.send('extensionSettingsEnableErrorCollection',
+                      [extension.id, String(e.target.checked)]);

[not at google - send to devlin, 2014/04/16 21:28:31]

weird that we're converting these to strings to pass to webui, but... well,
whatever, seems to be the practice.

[Devlin, 2014/04/16 22:50:41]

Yeah, I thought it was weird too.  I can only assume that it's to force a type,
rather than implicitly convert between int/bool.

+        });
+      }
+
       // The 'allow file:// access' checkbox.
       if (extension.wantsFileAccess) {
         var fileAccess = node.querySelector('.file-access-control');
         fileAccess.addEventListener('click', function(e) {
           chrome.send('extensionSettingsAllowFileAccess',
                       [extension.id, String(e.target.checked)]);
         });
         fileAccess.querySelector('input').checked = extension.allowFileAccess;
         fileAccess.hidden = false;
       }
@@ skipping 190 matching lines @@
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });