Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2380723003: CSS: test that transform properties create containing block (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: test that transform properties create containing block Add test that verifies 'perspective', 'translate', 'scale', 'rotate' create a containing block, just like 'transform'. Also check if listing these properties in will-change causes a containing block to be created. (These checks currently fail - see bug.) BUG=650607 Committed: https://crrev.com/ed716b1b2ca1c3cea338deff70de61b46c5d6ec8 Cr-Commit-Position: refs/heads/master@{#423431}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/transforms/containing-block.html View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/transforms/containing-block-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Eric Willigers
4 years, 2 months ago (2016-09-29 06:01:38 UTC) #3
alancutter (OOO until 2018)
lgtm
4 years, 2 months ago (2016-10-06 04:28:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380723003/20001
4 years, 2 months ago (2016-10-06 04:29:33 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 04:35:13 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 04:37:27 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed716b1b2ca1c3cea338deff70de61b46c5d6ec8
Cr-Commit-Position: refs/heads/master@{#423431}

Powered by Google App Engine
This is Rietveld 408576698