Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2380723002: Revert of ServiceWorker: Added --mojo-service-worker to the browser tests (Closed)

Created:
4 years, 2 months ago by jwd
Modified:
4 years, 2 months ago
Reviewers:
shimazu, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Added --mojo-service-worker to the browser tests (patchset #2 id:20001 of https://codereview.chromium.org/2357543002/ ) Reason for revert: Revert so a revert of https://codereview.chromium.org/2227593002 will compile. Original issue's description: > ServiceWorker: Added --mojo-service-worker to the browser tests > > In this patch, all browser tests are changed to IN_PROC_BROWSER_TEST_P > to use the parameterized tests for flipping the flag. > > BUG=629701 > > Committed: https://crrev.com/baa9cb520b6ee800f7633fb966474bf12325b8d9 > Cr-Commit-Position: refs/heads/master@{#421462} TBR=horo@chromium.org,shimazu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629701 Committed: https://crrev.com/9fad885c354ebf046e9506f85391cf4585991c05 Cr-Commit-Position: refs/heads/master@{#421518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -80 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 35 chunks +40 lines, -80 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jwd
Created Revert of ServiceWorker: Added --mojo-service-worker to the browser tests
4 years, 2 months ago (2016-09-28 14:20:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380723002/1
4 years, 2 months ago (2016-09-28 14:20:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 14:21:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9fad885c354ebf046e9506f85391cf4585991c05 Cr-Commit-Position: refs/heads/master@{#421518}
4 years, 2 months ago (2016-09-28 14:26:12 UTC) #6
shimazu
4 years, 2 months ago (2016-10-06 05:36:26 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2397523004/ by shimazu@chromium.org.

The reason for reverting is: A revert of
https://codereview.chromium.org/2227593002 is reverted..

Powered by Google App Engine
This is Rietveld 408576698