Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2380703002: Adjust use counters for editing and legacy events. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust use counters for editing and legacy events. Editing events incorrectly counted all the time even if there wasn't a listener. Only that the target had rareData on the element. I've re-enumerated the use counter values because they were completely wrong. For legacy events, fix the semantics but it is really a minor issue that I don't think deserves new enumeration values. BUG=612829 Committed: https://crrev.com/4908e484c88c0de62483404d6d6a63515acf67af Cr-Commit-Position: refs/heads/master@{#421825}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -32 lines) Patch
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dtapuska
On 2016/09/28 14:23:44, dtapuska wrote: > mailto:dtapuska@chromium.org changed reviewers: > + mailto:isherman@chromium.org, mailto:rbyers@chromium.org isherman@ I ...
4 years, 2 months ago (2016-09-28 14:24:17 UTC) #3
Rick Byers
LGTM I think renaming the broken enum values and creating new ones of the same ...
4 years, 2 months ago (2016-09-28 16:08:31 UTC) #4
Ilya Sherman
histograms.xml lgtm
4 years, 2 months ago (2016-09-28 23:26:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380703002/1
4 years, 2 months ago (2016-09-28 23:48:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/276588) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-28 23:52:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380703002/20001
4 years, 2 months ago (2016-09-29 13:40:11 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 15:27:31 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:29:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4908e484c88c0de62483404d6d6a63515acf67af
Cr-Commit-Position: refs/heads/master@{#421825}

Powered by Google App Engine
This is Rietveld 408576698