Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2380683003: add range check to service-side MapBufferRange (Closed)

Created:
4 years, 2 months ago by Kai Ninomiya
Modified:
4 years, 2 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add range check to service-side MapBufferRange BUG=650123 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6bf82374fb3a17659851bc4e830c063577ba80fd Cr-Commit-Position: refs/heads/master@{#422326}

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : remove flaky expectation #

Patch Set 4 : rebase over reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_buffers.cc View 1 2 3 9 chunks +8 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (18 generated)
Kai Ninomiya
PTAL
4 years, 2 months ago (2016-09-28 21:58:19 UTC) #4
Kai Ninomiya
PTAL
4 years, 2 months ago (2016-09-28 21:58:50 UTC) #7
Ken Russell (switch to Gerrit)
Kai, thank you for tracking this down and fixing it. It looks great overall. Could ...
4 years, 2 months ago (2016-09-30 01:06:07 UTC) #14
Zhenyao Mo
On 2016/09/30 01:06:07, Ken Russell wrote: > Kai, thank you for tracking this down and ...
4 years, 2 months ago (2016-09-30 20:02:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380683003/40001
4 years, 2 months ago (2016-09-30 21:23:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380683003/60001
4 years, 2 months ago (2016-10-01 18:56:22 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-01 19:45:51 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 19:47:14 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6bf82374fb3a17659851bc4e830c063577ba80fd
Cr-Commit-Position: refs/heads/master@{#422326}

Powered by Google App Engine
This is Rietveld 408576698