Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2380673002: Clean up code to use VideoFrameMetadata::MergeMetadataFrom() when appropriate. (Closed)

Created:
4 years, 2 months ago by Yeol Park
Modified:
4 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up code to use VideoFrameMetadata::MergeMetadataFrom() when appropriate. This issue tracks the work to replace the manual merging of the dictionary values with the new cleaner utility function. This patch is replaced the 'VideoFrameMetadata::MergeInternalValuesInto()' and 'VideoFrameMetadata::MergeInternalValuesFrom()' to 'VideoFrameMetadata::MergeMetadataFrom()'. BUG=592126 Committed: https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d Cr-Commit-Position: refs/heads/master@{#422007}

Patch Set 1 #

Patch Set 2 : Clean up code to use VideoFrameMetadata::MergeMetadataFrom() when appropriate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/base/video_frame_unittest.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 31 (19 generated)
Yeol Park
PTAL
4 years, 2 months ago (2016-09-28 12:03:37 UTC) #4
Yeol Park
Delete AUTHORS, and add one file.
4 years, 2 months ago (2016-09-29 07:07:24 UTC) #9
zino
On 2016/09/29 07:07:24, Park Yeol wrote: > Delete AUTHORS, and add one file. And please ...
4 years, 2 months ago (2016-09-29 07:14:55 UTC) #10
Yeol Park
On 2016/09/29 07:14:55, zino wrote: > On 2016/09/29 07:07:24, Park Yeol wrote: > > Delete ...
4 years, 2 months ago (2016-09-29 07:16:51 UTC) #12
Yeol Park
PTAL :) +danakj@ for cc/* +mcasas@ for content/renderer/media/* +chcunningham@, dalecurtis@ for media/*
4 years, 2 months ago (2016-09-29 10:54:30 UTC) #19
DaleCurtis
Thanks for the cleanup. lgtm
4 years, 2 months ago (2016-09-29 17:46:45 UTC) #20
danakj
cc LGTM
4 years, 2 months ago (2016-09-29 18:24:50 UTC) #21
mcasas
On 2016/09/29 18:24:50, danakj wrote: > cc LGTM my files lgtm (not needed but all ...
4 years, 2 months ago (2016-09-29 18:56:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380673002/20001
4 years, 2 months ago (2016-09-29 19:11:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380673002/20001
4 years, 2 months ago (2016-09-30 01:14:09 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 01:20:34 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 01:23:07 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bec217c6d06d0aa60f1a15a24dfef6419fcb57d
Cr-Commit-Position: refs/heads/master@{#422007}

Powered by Google App Engine
This is Rietveld 408576698