Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2380663002: Revert of [parser] Refactor of ParseClass* and ParseNativeDeclaration (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
nickie, adamk, marja
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [parser] Refactor of ParseClass* and ParseNativeDeclaration (patchset #7 id:120001 of https://codereview.chromium.org/2368083002/ ) Reason for revert: Blocks reverting https://codereview.chromium.org/2368313002 Original issue's description: > [parser] Refactor of ParseClass* and ParseNativeDeclaration > > This patch moves the following parsing method to ParserBase: > > - ParseClassDeclaration > - ParseClassLiteral > - ParseNativeDeclaration > > R=adamk@chromium.org, marja@chromium.org > BUG= > LOG=N > > Committed: https://crrev.com/7818355363b7a66ff7709e33c72bfdef5eb21450 > Cr-Commit-Position: refs/heads/master@{#39814} TBR=adamk@chromium.org,marja@chromium.org,nikolaos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/db6f3701ba4af005fafea2c8abe126d28ecd78c9 Cr-Commit-Position: refs/heads/master@{#39820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -371 lines) Patch
M src/parsing/parser.h View 6 chunks +11 lines, -25 lines 0 comments Download
M src/parsing/parser.cc View 8 chunks +235 lines, -151 lines 0 comments Download
M src/parsing/parser-base.h View 12 chunks +10 lines, -162 lines 0 comments Download
M src/parsing/preparser.h View 7 chunks +15 lines, -33 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +63 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
Created Revert of [parser] Refactor of ParseClass* and ParseNativeDeclaration
4 years, 2 months ago (2016-09-28 11:15:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380663002/1
4 years, 2 months ago (2016-09-28 11:16:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 11:16:14 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 11:16:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db6f3701ba4af005fafea2c8abe126d28ecd78c9
Cr-Commit-Position: refs/heads/master@{#39820}

Powered by Google App Engine
This is Rietveld 408576698