[tools] Add support to launch the replay server separately for callstats.py

[tools] Add support to launch the replay server separately for callstats.py

BUG=
NOTRY=true

Committed: https://crrev.com/8e283057aa864b0afb61bd210c62b77a0da4e9f4
Cr-Commit-Position: refs/heads/master@{#39816}

[Camillo Bruni, 2016-09-28 08:51:09]

cbruni@chromium.org changed reviewers:
+ nikolaos@chromium.org

[Camillo Bruni, 2016-09-28 08:51:09]

PTAL

[nickie, 2016-09-28 09:08:10]

LGTM, with two minor related comments that you may or may not want to address.

https://codereview.chromium.org/2380643002/diff/1/tools/callstats.py
File tools/callstats.py (right):

https://codereview.chromium.org/2380643002/diff/1/tools/callstats.py#newcode127
tools/callstats.py:127: user_data_dir="/var/tmp/`date +%S`"):
The default parameter here is probably not recommended as a temp directory,
unless somebody (the bots?) want it like this.  Lines 171-174 and the cleaning
up in lines 214-216 were used for this purpose.  As far as I can see, there are
no other call sites of this function, except for the one in line 178 and the
usage message.

https://codereview.chromium.org/2380643002/diff/1/tools/callstats.py#newcode294
tools/callstats.py:294: (" \\\n       
".join(get_chrome_flags()+get_chrome_replay_args(args))) +
Here the users will see the /var/tmp/`date` temp directory, which I suppose is
what you want...

[Camillo Bruni, 2016-09-28 09:35:31]

Description was changed from

==========
[tools] Add support to launch the replay server separately for callstats.py

BUG=
==========

to

==========
[tools] Add support to launch the replay server separately for callstats.py

BUG=
NOTRY=true
==========

[Camillo Bruni, 2016-09-28 09:35:35]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-09-28 09:35:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
nikolaos@chromium.org
Link to the patchset: https://codereview.chromium.org/2380643002/#ps60001
(title: "rename function")

[commit-bot: I haz the power, 2016-09-28 09:35:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 09:37:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-28 09:37:59]

Description was changed from

==========
[tools] Add support to launch the replay server separately for callstats.py

BUG=
NOTRY=true
==========

to

==========
[tools] Add support to launch the replay server separately for callstats.py

BUG=
NOTRY=true

Committed: https://crrev.com/8e283057aa864b0afb61bd210c62b77a0da4e9f4
Cr-Commit-Position: refs/heads/master@{#39816}
==========

[commit-bot: I haz the power, 2016-09-28 09:37:59]

Patchset 4 (id:??) landed as
https://crrev.com/8e283057aa864b0afb61bd210c62b77a0da4e9f4
Cr-Commit-Position: refs/heads/master@{#39816}

[Camillo Bruni, 2016-09-28 10:36:34]

https://codereview.chromium.org/2380643002/diff/1/tools/callstats.py
File tools/callstats.py (right):

https://codereview.chromium.org/2380643002/diff/1/tools/callstats.py#newcode127
tools/callstats.py:127: user_data_dir="/var/tmp/`date +%S`"):
On 2016/09/28 at 09:08:09, nickie wrote:
> The default parameter here is probably not recommended as a temp directory,
unless somebody (the bots?) want it like this.  Lines 171-174 and the cleaning
up in lines 214-216 were used for this purpose.  As far as I can see, there are
no other call sites of this function, except for the one in line 178 and the
usage message.

Will push the tmp dir flag to there.

https://codereview.chromium.org/2380643002/diff/1/tools/callstats.py#newcode294
tools/callstats.py:294: (" \\\n       
".join(get_chrome_flags()+get_chrome_replay_args(args))) +
On 2016/09/28 at 09:08:09, nickie wrote:
> Here the users will see the /var/tmp/`date` temp directory, which I suppose is
what you want...

right, made this more obvious by pushing down the parameters to here.