Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: ppapi/api/private/ppb_network_list_private.idl

Issue 23806003: Use PP_ArrayOutput and PPB_NetAddress in PPB_NetworkList_Private.. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/private/ppb_network_list_private.idl
diff --git a/ppapi/api/private/ppb_network_list_private.idl b/ppapi/api/private/ppb_network_list_private.idl
index 8ec330fb8883639c53fe43855e6711f77dfc2825..5c19a75565096f0baecd365a2d357ebee992a031 100644
--- a/ppapi/api/private/ppb_network_list_private.idl
+++ b/ppapi/api/private/ppb_network_list_private.idl
@@ -10,7 +10,7 @@
[generate_thunk]
label Chrome {
- M19 = 0.2
+ M31 = 0.3
};
/**
@@ -105,20 +105,21 @@ interface PPB_NetworkList_Private {
[in] uint32_t index);
/**
- * Gets list of IP addresses for the network interface with the
- * specified <code>index</code> and stores them in
- * <code>addresses</code>. If the caller didn't allocate sufficient
- * space to store all addresses, then only the first
- * <code>count</code> addresses are filled in.
+ * Gets list of IP addresses for a network interface.
*
- * @return Returns total number of IP addresses assigned to the
- * network interface or a negative error code.
+ * @param[in] resource A <code>PP_Resource</code> corresponding to a
yzshen1 2013/09/03 17:47:32 It would be nice to convert all other comments to
Sergey Ulanov 2013/09/03 23:42:54 Done.
+ * network list.
+ * @param[in] index Index of the network interface.
+ * @param[in] output An output array which will receive
+ * <code>PPB_NetAddress</code> resources on success. Please note that the
+ * ref count of those resources has already been increased byr the
yzshen1 2013/09/03 17:47:32 byr -> for.
Sergey Ulanov 2013/09/03 23:42:54 Done.
+ * caller.
+ *
+ * @return An error code from <code>pp_errors.h</code>.
*/
- int32_t GetIpAddresses(
- [in] PP_Resource resource,
- [in] uint32_t index,
- [inout, size_is(count)] PP_NetAddress_Private[] addresses,
- [in] uint32_t count);
+ int32_t GetIpAddresses([in] PP_Resource resource,
+ [in] uint32_t index,
+ [in] PP_ArrayOutput output);
/**
* @return Returns display name for the network interface with the

Powered by Google App Engine
This is Rietveld 408576698