Use PP_ArrayOutput and PPB_NetAddress in PPB_NetworkList_Private..

ppapi/tests/test_network_monitor_private.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_network_monitor_private.h"
 
 #include <string.h>
 
 #include "ppapi/cpp/instance_handle.h"
 #include "ppapi/cpp/module.h"
-#include "ppapi/cpp/private/net_address_private.h"
+#include "ppapi/cpp/net_address.h"
 #include "ppapi/cpp/private/network_list_private.h"
 #include "ppapi/cpp/private/network_monitor_private.h"
 #include "ppapi/tests/testing_instance.h"
 #include "ppapi/tests/test_utils.h"
 #include "ppapi/utility/private/network_list_observer_private.h"
 
 REGISTER_TEST_CASE(NetworkMonitorPrivate);
 
 namespace {
 
@@ skipping 63 matching lines @@
 
 std::string TestNetworkMonitorPrivate::VerifyNetworkList(
     const pp::NetworkListPrivate& network_list) {
   // Verify that there is at least one network interface.
   size_t count = network_list.GetCount();
   ASSERT_TRUE(count >= 1U);
 
   // Iterate over all interfaces and verify their properties.
   for (size_t iface = 0; iface < count; ++iface) {
     // Verify that the first interface has at least one address.
-    std::vector<PP_NetAddress_Private> addresses;
+    std::vector<pp::NetAddress> addresses;
     network_list.GetIpAddresses(iface, &addresses);
     ASSERT_TRUE(addresses.size() >= 1U);
     // Verify that the addresses are valid.
     for (size_t i = 0; i < addresses.size(); ++i) {
-      PP_NetAddressFamily_Private family =
-          pp::NetAddressPrivate::GetFamily(addresses[i]);
+      PP_NetAddress_Family family = addresses[i].GetFamily();
 
-      ASSERT_TRUE(family == PP_NETADDRESSFAMILY_PRIVATE_IPV4 ||
-                  family == PP_NETADDRESSFAMILY_PRIVATE_IPV6);
+      switch (family) {
+        case PP_NETADDRESS_FAMILY_IPV4: {
+          PP_NetAddress_IPv4 ipv4;
+          ASSERT_TRUE(addresses[i].DescribeAsIPv4Address(&ipv4));
 
-      char ip[16] = { 0 };
-      ASSERT_TRUE(pp::NetAddressPrivate::GetAddress(
-          addresses[i], ip, sizeof(ip)));
+          // Verify that the address is not zero.
+          bool all_zeros = true;
+          for (size_t j = 0; j < sizeof(ipv4.addr); ++j) {
+            if (ipv4.addr[j] != 0) {
+              all_zeros = false;

[yzshen1, 2013/09/03 17:47:32]

nit: Please consider adding break;

[Sergey Ulanov, 2013/09/03 23:42:54]

Done.

+            }
+          }
+          ASSERT_TRUE(!all_zeros);
 
-      // Verify that the address is not zero.
-      size_t j;
-      for (j = 0; j < sizeof(ip); ++j) {
-        if (ip[j] != 0)
+          // Verify that port is set to 0.
+          ASSERT_TRUE(ipv4.port == 0);
           break;
+        }
+
+        case PP_NETADDRESS_FAMILY_IPV6: {
+          PP_NetAddress_IPv6 ipv6;
+          ASSERT_TRUE(addresses[i].DescribeAsIPv6Address(&ipv6));
+
+          // Verify that the address is not zero.
+          bool all_zeros = true;
+          for (size_t j = 0; j < sizeof(ipv6.addr); ++j) {
+            if (ipv6.addr[j] != 0) {
+              all_zeros = false;

[yzshen1, 2013/09/03 17:47:32]

ditto.

[Sergey Ulanov, 2013/09/03 23:42:54]

Done.

+            }
+          }
+          ASSERT_TRUE(!all_zeros);
+
+          // Verify that port is set to 0.
+          ASSERT_TRUE(ipv6.port == 0);
+          break;
+        }
+
+        default:
+          ASSERT_TRUE(false);
       }
-      ASSERT_TRUE(j != addresses[i].size);
-
-      // Verify that port is set to 0.
-      ASSERT_TRUE(pp::NetAddressPrivate::GetPort(addresses[i]) == 0);
     }
 
     // Verify that each interface has a unique name and a display name.
     ASSERT_FALSE(network_list.GetName(iface).empty());
     ASSERT_FALSE(network_list.GetDisplayName(iface).empty());
 
     PP_NetworkListType_Private type = network_list.GetType(iface);
     ASSERT_TRUE(type >= PP_NETWORKLIST_UNKNOWN);
     ASSERT_TRUE(type <= PP_NETWORKLIST_CELLULAR);
 
     PP_NetworkListState_Private state = network_list.GetState(iface);
     ASSERT_TRUE(state >= PP_NETWORKLIST_DOWN);
     ASSERT_TRUE(state <= PP_NETWORKLIST_UP);
   }
 
-  // Try to call GetIpAddresses() without C++ wrapper and verify that
-  // it always returns correct value.
-  const PPB_NetworkList_Private* interface =
-      static_cast<const PPB_NetworkList_Private*>(
-          pp::Module::Get()->GetBrowserInterface(
-              PPB_NETWORKLIST_PRIVATE_INTERFACE));
-  ASSERT_TRUE(interface);
-  std::vector<PP_NetAddress_Private> addresses;
-  network_list.GetIpAddresses(0, &addresses);
-  size_t address_count = addresses.size();
-  addresses.resize(addresses.size() + 3);
-  for (size_t i = 0; i < addresses.size(); ++i) {
-    const char kFillValue = 123;
-    memset(&addresses.front(), kFillValue,
-           addresses.size() * sizeof(PP_NetAddress_Private));
-    int result = interface->GetIpAddresses(network_list.pp_resource(), 0,
-                                           &addresses.front(), i);
-    ASSERT_EQ(result, static_cast<int>(address_count));
-
-    // Verify that nothing outside the buffer was touched.
-    for (char* pos = reinterpret_cast<char*>(&addresses[result]);
-         pos != reinterpret_cast<char*>(&addresses[0] + addresses.size());
-         ++pos) {
-      ASSERT_TRUE(*pos == kFillValue);
-    }
-  }
-
   PASS();
 }
 
 std::string TestNetworkMonitorPrivate::TestBasic() {
   CallbackData callback_data(instance_->pp_instance());
 
   pp::NetworkMonitorPrivate network_monitor(
       instance_, &TestCallback, &callback_data);
   callback_data.event.Wait();
   ASSERT_EQ(callback_data.call_counter, 1);
@@ skipping 40 matching lines @@
 
   PASS();
 }
 
 std::string TestNetworkMonitorPrivate::TestListObserver() {
   TestNetworkListObserver observer(instance_);
   observer.event.Wait();
   ASSERT_SUBTEST_SUCCESS(VerifyNetworkList(observer.current_list));
   PASS();
 }