Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: test/cctest/heap/test-incremental-marking.cc

Issue 2380583002: [tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Plat… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/libplatform/default-platform.h ('k') | test/cctest/test-trace-event.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 6
7 #ifdef __linux__ 7 #ifdef __linux__
8 #include <errno.h> 8 #include <errno.h>
9 #include <fcntl.h> 9 #include <fcntl.h>
10 #include <sys/stat.h> 10 #include <sys/stat.h>
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 61
62 bool PendingTask() { return task_ != nullptr; } 62 bool PendingTask() { return task_ != nullptr; }
63 63
64 void PerformTask() { 64 void PerformTask() {
65 Task* task = task_; 65 Task* task = task_;
66 task_ = nullptr; 66 task_ = nullptr;
67 task->Run(); 67 task->Run();
68 delete task; 68 delete task;
69 } 69 }
70 70
71 using Platform::AddTraceEvent;
71 uint64_t AddTraceEvent(char phase, const uint8_t* categoryEnabledFlag, 72 uint64_t AddTraceEvent(char phase, const uint8_t* categoryEnabledFlag,
72 const char* name, const char* scope, uint64_t id, 73 const char* name, const char* scope, uint64_t id,
73 uint64_t bind_id, int numArgs, const char** argNames, 74 uint64_t bind_id, int numArgs, const char** argNames,
74 const uint8_t* argTypes, const uint64_t* argValues, 75 const uint8_t* argTypes, const uint64_t* argValues,
75 unsigned int flags) override { 76 unsigned int flags) override {
76 return 0; 77 return 0;
77 } 78 }
78 79
79 void UpdateTraceEventDuration(const uint8_t* categoryEnabledFlag, 80 void UpdateTraceEventDuration(const uint8_t* categoryEnabledFlag,
80 const char* name, uint64_t handle) override {} 81 const char* name, uint64_t handle) override {}
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 CHECK(platform.PendingTask()); 135 CHECK(platform.PendingTask());
135 while (platform.PendingTask()) { 136 while (platform.PendingTask()) {
136 platform.PerformTask(); 137 platform.PerformTask();
137 } 138 }
138 CHECK(marking->IsStopped()); 139 CHECK(marking->IsStopped());
139 i::V8::SetPlatformForTesting(old_platform); 140 i::V8::SetPlatformForTesting(old_platform);
140 } 141 }
141 142
142 } // namespace internal 143 } // namespace internal
143 } // namespace v8 144 } // namespace v8
OLDNEW
« no previous file with comments | « src/libplatform/default-platform.h ('k') | test/cctest/test-trace-event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698