[tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Plat…

[tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in Class derived from Platform Class.

  The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc compilation fail for v8 debug mode.
  The error message was:
  In file included from .././include/libplatform/v8-tracing.h:13:0,
                   from .././src/libplatform/default-platform.h:14,
                   from ../src/libplatform/default-platform.cc:5:
  .././include/v8-platform.h:169:20: error: ‘virtual uint64_t v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, unsigned int)’ was hidden [-Werror=overloaded-virtual]
     virtual uint64_t AddTraceEvent(
                      ^
  In file included from ../src/libplatform/default-platform.cc:5:0:
  .././src/libplatform/default-platform.h:55:12: error:   by ‘virtual uint64_t v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*, const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’ [-Werror=overloaded-virtual]
     uint64_t AddTraceEvent(
              ^

  This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all declarations of AddTraceEvent functions in Classes derived from Platform Class.

BUG=

Committed: https://crrev.com/990a8e391339ab3a9238eff4f9ad904f99c9b930
Cr-Commit-Position: refs/heads/master@{#39810}

[zhengxing.li, 2016-09-28 06:31:48]

zhengxing.li@intel.com changed reviewers:
+ alph@chromium.org, bmeurer@chromium.org, caseq@chromium.org,
titzer@chromium.org

[zhengxing.li, 2016-09-28 06:31:49]

PTAL, thanks!

[Benedikt Meurer, 2016-09-28 08:17:45]

LGTM.

[zhengxing.li, 2016-09-28 08:18:12]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-09-28 08:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2016-09-28 08:45:57]

Thanks for the fix!

FYI: I'm going to remove the legacy AddTraceEvent as soon as gin part lands
https://codereview.chromium.org/2368483002/

[commit-bot: I haz the power, 2016-09-28 08:47:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-28 08:47:40]

Description was changed from

==========
[tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in
Class derived from Platform Class.

  The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc
compilation fail for v8 debug mode.
  The error message was:
  In file included from .././include/libplatform/v8-tracing.h:13:0,
                   from .././src/libplatform/default-platform.h:14,
                   from ../src/libplatform/default-platform.cc:5:
  .././include/v8-platform.h:169:20: error: ‘virtual uint64_t
v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*,
uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*,
unsigned int)’ was hidden [-Werror=overloaded-virtual]
     virtual uint64_t AddTraceEvent(
                      ^
  In file included from ../src/libplatform/default-platform.cc:5:0:
  .././src/libplatform/default-platform.h:55:12: error:   by ‘virtual uint64_t
v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*,
const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const
uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’
[-Werror=overloaded-virtual]
     uint64_t AddTraceEvent(
              ^

  This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all
declarations of AddTraceEvent functions in Classes derived from Platform Class.

BUG=
==========

to

==========
[tracing] Avoid Gcc compilation fail by declaring AddTraceEvent function in
Class derived from Platform Class.

  The CL #39789 (https://codereview.chromium.org/2367603002 ) caused the Gcc
compilation fail for v8 debug mode.
  The error message was:
  In file included from .././include/libplatform/v8-tracing.h:13:0,
                   from .././src/libplatform/default-platform.h:14,
                   from ../src/libplatform/default-platform.cc:5:
  .././include/v8-platform.h:169:20: error: ‘virtual uint64_t
v8::Platform::AddTraceEvent(char, const uint8_t*, const char*, const char*,
uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const uint64_t*,
unsigned int)’ was hidden [-Werror=overloaded-virtual]
     virtual uint64_t AddTraceEvent(
                      ^
  In file included from ../src/libplatform/default-platform.cc:5:0:
  .././src/libplatform/default-platform.h:55:12: error:   by ‘virtual uint64_t
v8::platform::DefaultPlatform::AddTraceEvent(char, const uint8_t*, const char*,
const char*, uint64_t, uint64_t, int32_t, const char**, const uint8_t*, const
uint64_t*, std::unique_ptr<v8::ConvertableToTraceFormat>*, unsigned int)’
[-Werror=overloaded-virtual]
     uint64_t AddTraceEvent(
              ^

  This CL fixed this issue by adding "using Platform::AddTraceEvent;" before all
declarations of AddTraceEvent functions in Classes derived from Platform Class.

BUG=

Committed: https://crrev.com/990a8e391339ab3a9238eff4f9ad904f99c9b930
Cr-Commit-Position: refs/heads/master@{#39810}
==========

[commit-bot: I haz the power, 2016-09-28 08:47:41]

Patchset 1 (id:??) landed as
https://crrev.com/990a8e391339ab3a9238eff4f9ad904f99c9b930
Cr-Commit-Position: refs/heads/master@{#39810}