Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2380563005: [code-stubs] Add LoadMapElementsKind helper (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add LoadMapElementsKind helper Committed: https://crrev.com/e82ad05c6b724df080bf6f3603b52ab5e5ab7755 Cr-Commit-Position: refs/heads/master@{#39914}

Patch Set 1 #

Patch Set 2 : comitting all files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/builtins/builtins-array.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/code-stub-assembler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Camillo Bruni
PTAL
4 years, 2 months ago (2016-09-30 11:02:23 UTC) #2
Jakob Kummerow
lgtm
4 years, 2 months ago (2016-09-30 11:07:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380563005/20001
4 years, 2 months ago (2016-09-30 11:13:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 11:44:06 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 11:44:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e82ad05c6b724df080bf6f3603b52ab5e5ab7755
Cr-Commit-Position: refs/heads/master@{#39914}

Powered by Google App Engine
This is Rietveld 408576698