Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Issue 2380533003: Revert of In rebaseline.py, update SCM and expectations all at once after all commands. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of In rebaseline.py, update SCM and expectations all at once after all commands. (patchset #2 id:20001 of https://codereview.chromium.org/2341643005/ ) Reason for revert: Caused rebaseline-o-matic to fail: http://crrev.com/650944 Could be re-landed with a fix. Original issue's description: > In rebaseline.py, update SCM and expectations all at once after all commands. > > This is meant to fix http://crbug.com/639410 by making it so that if there are files that are both added and deleted (e.g. downloaded and then de-duped), they won't ever be staged since all changes would be aggregated and de-duped before running git add/rm. > > BUG=639410 > > Committed: https://crrev.com/34fdc9df872c6ce13e6c3c546084435321d4e882 > Cr-Commit-Position: refs/heads/master@{#420461} TBR=dpranke@chromium.org,wkorman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=639410 Committed: https://crrev.com/48a6db917e5860b4798c5c16565bbc03304433d3 Cr-Commit-Position: refs/heads/master@{#421556}

Patch Set 1 #

Patch Set 2 : Rebase revert patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -140 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 5 chunks +46 lines, -47 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
qyearsley
Created Revert of In rebaseline.py, update SCM and expectations all at once after all commands.
4 years, 2 months ago (2016-09-28 16:03:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380533003/1
4 years, 2 months ago (2016-09-28 16:03:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/304336)
4 years, 2 months ago (2016-09-28 16:06:19 UTC) #5
Dirk Pranke
lgtm
4 years, 2 months ago (2016-09-28 16:33:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380533003/120001
4 years, 2 months ago (2016-09-28 16:47:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 2 months ago (2016-09-28 17:28:05 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/48a6db917e5860b4798c5c16565bbc03304433d3 Cr-Commit-Position: refs/heads/master@{#421556}
4 years, 2 months ago (2016-09-28 17:31:40 UTC) #14
qyearsley
4 years, 2 months ago (2016-10-04 22:27:03 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:120001) has been created in
https://codereview.chromium.org/2396433004/ by qyearsley@chromium.org.

The reason for reverting is: Create reland patch.

Powered by Google App Engine
This is Rietveld 408576698