DescriptionRevert of Fix an issue that audio and video may run out of sync (https://codereview.chromium.org/215783002/)
Reason for revert:
Android Tests failed
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13105
Note: Google Test filter = MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from MediaSourcePlayerTest
[ RUN ] MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved
../../media/base/android/media_source_player_unittest.cc:2088: Failure
Expected: (current_time.InMillisecondsF()) < (player_.GetCurrentTime().InMillisecondsF()), actual: 0 vs 0
[ FAILED ] MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved (305 ms)
[----------] 1 test from MediaSourcePlayerTest (305 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (307 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved
Original issue's description:
> Fix an issue that audio and video may run out of sync
>
> This CL fixes 3 issues:
> 1. In ProcessPendingEvents(), if there is a non-seek pending event, UpdateTimestamps() will not get called.
> This is probably the number 1 reason that a/v lose sync.
> 2. MSP use its internal clock to estimate the current presentation time.
> However, hardware may consume data at a different rate.
> Passing the current frame position from AudioTrack to MSP so we get a better estimation of the current time.
> 3. When config change comes, We don't need to reset the clock if audio decoder is not recreated.
>
> BUG=351722
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263754
TBR=wolenetz@chromium.org,igsolla@chromium.org,acolwell@chromium.org,qinmin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351722
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263795
Patch Set 1 #
Created: 6 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|