Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 238053004: Revert of Fix an issue that audio and video may run out of sync (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, gunsch
Visibility:
Public.

Description

Revert of Fix an issue that audio and video may run out of sync (https://codereview.chromium.org/215783002/) Reason for revert: Android Tests failed http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13105 Note: Google Test filter = MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from MediaSourcePlayerTest [ RUN ] MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved ../../media/base/android/media_source_player_unittest.cc:2088: Failure Expected: (current_time.InMillisecondsF()) < (player_.GetCurrentTime().InMillisecondsF()), actual: 0 vs 0 [ FAILED ] MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved (305 ms) [----------] 1 test from MediaSourcePlayerTest (305 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (307 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] MediaSourcePlayerTest.CurrentTimeUpdatedWhileDecoderStarved Original issue's description: > Fix an issue that audio and video may run out of sync > > This CL fixes 3 issues: > 1. In ProcessPendingEvents(), if there is a non-seek pending event, UpdateTimestamps() will not get called. > This is probably the number 1 reason that a/v lose sync. > 2. MSP use its internal clock to estimate the current presentation time. > However, hardware may consume data at a different rate. > Passing the current frame position from AudioTrack to MSP so we get a better estimation of the current time. > 3. When config change comes, We don't need to reset the clock if audio decoder is not recreated. > > BUG=351722 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263754 TBR=wolenetz@chromium.org,igsolla@chromium.org,acolwell@chromium.org,qinmin@chromium.org NOTREECHECKS=true NOTRY=true BUG=351722 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -216 lines) Patch
M media/base/android/audio_decoder_job.h View 3 chunks +1 line, -14 lines 0 comments Download
M media/base/android/audio_decoder_job.cc View 3 chunks +8 lines, -39 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 2 chunks +12 lines, -32 lines 0 comments Download
M media/base/android/media_codec_bridge.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/base/android/media_codec_bridge.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/base/android/media_decoder_job.h View 3 chunks +8 lines, -10 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 11 chunks +16 lines, -18 lines 0 comments Download
M media/base/android/media_source_player.h View 5 chunks +12 lines, -12 lines 0 comments Download
M media/base/android/media_source_player.cc View 13 chunks +42 lines, -31 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M media/base/android/video_decoder_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/video_decoder_job.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
horo
Created Revert of Fix an issue that audio and video may run out of sync
6 years, 8 months ago (2014-04-15 05:45:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/238053004/1
6 years, 8 months ago (2014-04-15 05:47:08 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 05:49:49 UTC) #3
Message was sent while issue was closed.
Change committed as 263795

Powered by Google App Engine
This is Rietveld 408576698