Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2380523005:
[interpreter] Specify and type the parameters of the Interpreter*Descriptors. (Closed)
Description[interpreter] Specify and type the parameters of the Interpreter*Descriptors.
BUG=
Committed: https://crrev.com/4b27480e11ec30fb46da836dc2bd58a93e66be12
Cr-Commit-Position: refs/heads/master@{#39867}
Patch Set 1 #Patch Set 2 : Update. #Patch Set 3 : Update. #
Messages
Total messages: 25 (19 generated)
Description was changed from ========== [interpreter] Specify and type the parameters of the Interpreter*Descriptors. BUG= ========== to ========== [interpreter] Specify and type the parameters of the Interpreter*Descriptors. BUG= ==========
epertoso@chromium.org changed reviewers: + rmcilroy@chromium.org
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
epertoso@chromium.org changed reviewers: + mstarzinger@chromium.org - rmcilroy@chromium.org
LGTM.
The CQ bit was checked by epertoso@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Specify and type the parameters of the Interpreter*Descriptors. BUG= ========== to ========== [interpreter] Specify and type the parameters of the Interpreter*Descriptors. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Specify and type the parameters of the Interpreter*Descriptors. BUG= ========== to ========== [interpreter] Specify and type the parameters of the Interpreter*Descriptors. BUG= Committed: https://crrev.com/4b27480e11ec30fb46da836dc2bd58a93e66be12 Cr-Commit-Position: refs/heads/master@{#39867} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4b27480e11ec30fb46da836dc2bd58a93e66be12 Cr-Commit-Position: refs/heads/master@{#39867}
Message was sent while issue was closed.
rmcilroy@chromium.org changed reviewers: + rmcilroy@chromium.org
Message was sent while issue was closed.
Lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
