Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2380473002: Change the linebreak behavior of minlength and maxlength attributes of TEXTAREA. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the linebreak behavior of minlength and maxlength attributes of TEXTAREA. Change it in response to a specification change, and to improve compatibility with Firefox and Edge. Old behavior: CRLF, CR, or LF is counted as 2 because we limited the submission value. New behavior: CRLF, CR, or LF is counted as 1 because we limit the API value. We can use HTMLTextAreaElement::value().length() as is because it's the API value, and other string input should be counted by computeLengthForAPIValue(). Approved intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/MkSfvCan7kY/PgniO8jwAAAJ BUG=624361 Committed: https://crrev.com/a15474ff7adff41a8956ab436ac63a7d5b7a090f Cr-Commit-Position: refs/heads/master@{#421445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-maxlength.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-maxlength-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/validationMessage-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 7 chunks +17 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElementTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
tkent
keishi, would you review this please?
4 years, 2 months ago (2016-09-28 03:49:42 UTC) #14
keishi
LGTM
4 years, 2 months ago (2016-09-28 04:10:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380473002/20001
4 years, 2 months ago (2016-09-28 04:16:43 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-09-28 04:21:35 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 04:24:05 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a15474ff7adff41a8956ab436ac63a7d5b7a090f
Cr-Commit-Position: refs/heads/master@{#421445}

Powered by Google App Engine
This is Rietveld 408576698