Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2380463006: [wasm] Properly handlify WasmCompiledModule::Clone. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Properly handlify WasmCompiledModule::Clone. This is to avoid a dereference of the unhandlified {this} reference after handlified allocation functions have been called. Combining handlified and unhandlified style is inherently unsafe. R=titzer@chromium.org Committed: https://crrev.com/2ab7a917c9da03ef352e557c95e50820304fb7de Cr-Commit-Position: refs/heads/master@{#39921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/wasm/wasm-module.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
This is to fix the "mjsunit/wasm/asm-wasm" flakes on the waterfall.
4 years, 2 months ago (2016-09-30 16:21:07 UTC) #5
titzer
lgtm
4 years, 2 months ago (2016-09-30 16:27:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380463006/1
4 years, 2 months ago (2016-09-30 16:29:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 16:31:20 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 16:31:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ab7a917c9da03ef352e557c95e50820304fb7de
Cr-Commit-Position: refs/heads/master@{#39921}

Powered by Google App Engine
This is Rietveld 408576698