Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2380463005: It2Me Host cleanup - Remove task_runner_ (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

It2Me Host cleanup - Remove task_runner_ This member seems to have been used when we ran code using a plugin_task_runner that was passed in to us, however that is no longer the case and we can now use the host_context_ for all of our task running needs. I also removed some invalid DCHECKs that were required in the past, but were incorrectly updated in previous CLs and are no longer useful. BUG=650792 Committed: https://crrev.com/61431fea97b63bf714d7b411e68b9321d09bbb38 Cr-Commit-Position: refs/heads/master@{#421905}

Patch Set 1 #

Patch Set 2 : Removing unused header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -32 lines) Patch
M remoting/host/it2me/it2me_host.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 8 chunks +13 lines, -15 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
joedow
PTAL! I will send out a second CL with the changes for confirmation_dialog_ removal once ...
4 years, 2 months ago (2016-09-29 18:46:27 UTC) #6
Sergey Ulanov
lgtm
4 years, 2 months ago (2016-09-29 19:30:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380463005/20001
4 years, 2 months ago (2016-09-29 19:31:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 19:39:28 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 19:44:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61431fea97b63bf714d7b411e68b9321d09bbb38
Cr-Commit-Position: refs/heads/master@{#421905}

Powered by Google App Engine
This is Rietveld 408576698