Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: android_webview/native/aw_settings.cc

Issue 238043003: WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_settings.h" 5 #include "android_webview/native/aw_settings.h"
6 6
7 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h" 7 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h"
8 #include "android_webview/common/aw_content_client.h" 8 #include "android_webview/common/aw_content_client.h"
9 #include "android_webview/native/aw_contents.h" 9 #include "android_webview/native/aw_contents.h"
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 jlong web_contents) { 343 jlong web_contents) {
344 AwSettings* settings = new AwSettings(env, obj, web_contents); 344 AwSettings* settings = new AwSettings(env, obj, web_contents);
345 return reinterpret_cast<intptr_t>(settings); 345 return reinterpret_cast<intptr_t>(settings);
346 } 346 }
347 347
348 static jstring GetDefaultUserAgent(JNIEnv* env, jclass clazz) { 348 static jstring GetDefaultUserAgent(JNIEnv* env, jclass clazz) {
349 return base::android::ConvertUTF8ToJavaString(env, GetUserAgent()).Release(); 349 return base::android::ConvertUTF8ToJavaString(env, GetUserAgent()).Release();
350 } 350 }
351 351
352 bool RegisterAwSettings(JNIEnv* env) { 352 bool RegisterAwSettings(JNIEnv* env) {
353 return RegisterNativesImpl(env) >= 0; 353 return RegisterNativesImpl(env);
354 } 354 }
355 355
356 } // namespace android_webview 356 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_resource.cc ('k') | android_webview/native/external_video_surface_container_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698