Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: android_webview/native/aw_resource.cc

Issue 238043003: WebView: RegisterNativesImpl() returns bool; don't compare it for >= 0. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_resource.h" 5 #include "android_webview/native/aw_resource.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/android/scoped_java_ref.h" 8 #include "base/android/scoped_java_ref.h"
9 #include "jni/AwResource_jni.h" 9 #include "jni/AwResource_jni.h"
10 10
(...skipping 20 matching lines...) Expand all
31 } 31 }
32 32
33 std::string GetDefaultTextEncoding() { 33 std::string GetDefaultTextEncoding() {
34 JNIEnv* env = base::android::AttachCurrentThread(); 34 JNIEnv* env = base::android::AttachCurrentThread();
35 ScopedJavaLocalRef<jstring> encoding = 35 ScopedJavaLocalRef<jstring> encoding =
36 Java_AwResource_getDefaultTextEncoding(env); 36 Java_AwResource_getDefaultTextEncoding(env);
37 return base::android::ConvertJavaStringToUTF8(encoding); 37 return base::android::ConvertJavaStringToUTF8(encoding);
38 } 38 }
39 39
40 bool RegisterAwResource(JNIEnv* env) { 40 bool RegisterAwResource(JNIEnv* env) {
41 return RegisterNativesImpl(env) >= 0; 41 return RegisterNativesImpl(env);
42 } 42 }
43 43
44 } // namespace AwResource 44 } // namespace AwResource
45 } // namespace android_webview 45 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_quota_manager_bridge_impl.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698