Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: content/browser/service_worker/service_worker_process_manager.h

Issue 238043002: Teach EmbeddedWorkerInstance to create a process when it needs one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Handle 2 places where context_ could be NULL. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROCESS_MANAGER_H_
6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROCESS_MANAGER_H_
7
8 #include <vector>
9
10 #include "base/callback.h"
11 #include "base/memory/scoped_ptr.h"
12 #include "base/memory/weak_ptr.h"
13 #include "content/common/service_worker/service_worker_status_code.h"
14
15 class GURL;
16
17 namespace content {
18
19 class BrowserContext;
20 class ServiceWorkerContextWrapper;
21
22 // Interacts with the UI thread to keep RenderProcessHosts alive while the
23 // ServiceWorker system is using them. Each instance of
24 // ServiceWorkerProcessManager is destroyed on the UI thread shortly after its
25 // ServiceWorkerContextCore is destroyed on the IO thread.
26 class CONTENT_EXPORT ServiceWorkerProcessManager {
27 public:
28 // |*this| must be owned by |context_wrapper|->context().
michaeln 2014/04/29 19:08:45 Hmmm... does this create a reference cycle? Wrapp
Jeffrey Yasskin 2014/04/29 19:13:25 Yes. The cycle is broken in Wrapper::Shutdown(). I
29 explicit ServiceWorkerProcessManager(
30 ServiceWorkerContextWrapper* context_wrapper);
31
32 ~ServiceWorkerProcessManager();
33
34 // Returns a reference to a running process suitable for starting the Service
35 // Worker at |script_url|. Processes in |process_ids| will be checked in order
36 // for existence, and if none exist, then a new process will be created. Posts
37 // |callback| to the IO thread to indicate whether creation succeeded and the
38 // process ID that has a new reference.
39 //
40 // Allocation can fail with SERVICE_WORKER_ERROR_START_WORKER_FAILED if
41 // RenderProcessHost::Init fails.
42 void AllocateWorkerProcess(
43 const std::vector<int>& process_ids,
44 const GURL& script_url,
45 const base::Callback<void(ServiceWorkerStatusCode, int process_id)>&
46 callback) const;
47
48 // Drops a reference to a process that was running a Service Worker. This
49 // must match a call to AllocateWorkerProcess.
50 void ReleaseWorkerProcess(int process_id);
51
52 // |increment_for_test| and |decrement_for_test| define how to look up a
53 // process by ID and increment or decrement its worker reference count. This
54 // must be called before any reference to this object escapes to another
55 // thread, and is considered part of construction.
56 void SetProcessRefcountOpsForTest(
57 const base::Callback<bool(int)>& increment_for_test,
58 const base::Callback<bool(int)>& decrement_for_test);
59
60 private:
61 bool IncrementWorkerRefcountByPid(int process_id) const;
62 bool DecrementWorkerRefcountByPid(int process_id) const;
63
64 // These fields are only accessed on the UI thread after construction.
65 scoped_refptr<ServiceWorkerContextWrapper> context_wrapper_;
66 base::Callback<bool(int)> increment_for_test_;
67 base::Callback<bool(int)> decrement_for_test_;
68
69 // Used to double-check that we don't access *this after it's destroyed.
70 base::WeakPtrFactory<ServiceWorkerProcessManager> weak_this_factory_;
71 base::WeakPtr<ServiceWorkerProcessManager> weak_this_;
72 };
73
74 } // namespace content
75
76 namespace base {
77 // Specialized to post the deletion to the UI thread.
78 template <>
79 struct CONTENT_EXPORT DefaultDeleter<content::ServiceWorkerProcessManager> {
80 void operator()(content::ServiceWorkerProcessManager* ptr) const;
81 };
82 } // namespace base
83
84 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_PROCESS_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698