Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2380413002: [DevTools] prepapre for null from createCallFrameLiveLocation (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] prepapre for null from createCallFrameLiveLocation BUG=chromium:632933 R=lushnikov@chromium.org Committed: https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51 Cr-Commit-Position: refs/heads/master@{#422600}

Patch Set 1 #

Patch Set 2 : a #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 1 2 chunks +6 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
kozy
Andrey, please take a look! https://codereview.chromium.org/2380413002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js File third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js (right): https://codereview.chromium.org/2380413002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js#newcode607 third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js:607: this._locations.add(binding.createLiveLocation(location, this._scheduleUpdate.bind(this), locationPool)); We ...
4 years, 2 months ago (2016-09-30 19:26:33 UTC) #1
lushnikov
lgtm
4 years, 2 months ago (2016-10-03 20:55:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380413002/20001
4 years, 2 months ago (2016-10-03 21:04:24 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 23:39:29 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:43:34 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/84d65719f2ba3204b4c233a4ab0c4a2afdd8db51
Cr-Commit-Position: refs/heads/master@{#422600}

Powered by Google App Engine
This is Rietveld 408576698