Issue 23804007: Revert 221989 "Revert 221946 "[Android WebView] Enable spatial n..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23804007: Revert 221989 "Revert 221946 "[Android WebView] Enable spatial n..." (Closed)

Created:
7 years, 3 months ago by henrika (OOO until Aug 14)

Modified:
7 years, 3 months ago

Reviewers:
henrika (OOO until Aug 14)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 221989 "Revert 221946 "[Android WebView] Enable spatial n..." > Revert 221946 "[Android WebView] Enable spatial navigation / DPAD" > > > [Android WebView] Enable spatial navigation / DPAD > > > > Turn on the --enable-spatial-navigation flag, and also bubble up > > unhandled DPAD events to the neighboring views in the view tree. > > Likewise, WebContentsDelegate::TakeFocus() bubble to logical next > > or previous neighbor view. > > > > Also disabled the FileSystem API while in the area updating flags. > > > > BUG=286698 > > > > Review URL: https://chromiumcodereview.appspot.com/23619024 > > TBR=joth@chromium.org > > Review URL: https://codereview.chromium.org/23494033 TBR=henrika@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222002

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -2 lines)			Patch
M	trunk/src/android_webview/java/src/org/chromium/android_webview/AwContents.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java	View	3 chunks	+41 lines, -1 line	0 comments	Download
M	trunk/src/android_webview/lib/main/aw_main_delegate.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

henrika (OOO until Aug 14)

7 years, 3 months ago (2013-09-09 11:03:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r222002.