Issue 23804006: Leverage the fact that we already know the array size in V8Binding's array converting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23804006: Leverage the fact that we already know the array size in V8Binding's array converting (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Leverage the fact that we already know the array size in V8Binding's array converting Leverage the fact that we already know the array size in V8Binding's array converting. Use Vector::reserveInitialCapacity(length) to make sure we allocate enough memory for all the elements. This allows us to use Vector::uncheckedAppend() instead of Vector::append() which bypasses capacity checks for each loop iteration. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157463