Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7157)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 23804002: Make OmniboxEditModel::UpdatePermanentText() fetch the new text itself rather (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
===================================================================
--- chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (revision 220446)
+++ chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (working copy)
@@ -30,6 +30,7 @@
#include "chrome/browser/ui/omnibox/omnibox_popup_model.h"
#include "chrome/browser/ui/omnibox/omnibox_view.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/toolbar/test_toolbar_model.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
@@ -1672,17 +1673,21 @@
#endif // defined(TOOLKIT_VIEWS)
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CopyURLToClipboard) {
+ // Set permanent text thus making sure that omnibox treats 'google.com'
+ // as URL (not as ordinary user input).
+ TestToolbarModel* test_toolbar_model = new TestToolbarModel;
+ scoped_ptr<ToolbarModel> toolbar_model(test_toolbar_model);
+ test_toolbar_model->set_text(ASCIIToUTF16("http://www.google.com/"));
+ browser()->swap_toolbar_models(&toolbar_model);
OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
+ OmniboxEditModel* edit_model = omnibox_view->model();
+ ASSERT_NE(static_cast<OmniboxEditModel*>(NULL), edit_model);
+ edit_model->UpdatePermanentText();
+
const char* target_url = "http://www.google.com/calendar";
omnibox_view->SetUserText(ASCIIToUTF16(target_url));
- // Set permanent text thus making sure that omnibox treats 'google.com'
- // as URL (not as ordinary user input).
- OmniboxEditModel* edit_model = omnibox_view->model();
- ASSERT_NE(static_cast<OmniboxEditModel*>(NULL), edit_model);
- edit_model->UpdatePermanentText(ASCIIToUTF16("http://www.google.com/"));
-
// Location bar must have focus.
chrome::FocusLocationBar(browser());
ASSERT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
@@ -1715,17 +1720,21 @@
}
IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CutURLToClipboard) {
+ // Set permanent text thus making sure that omnibox treats 'google.com'
+ // as URL (not as ordinary user input).
+ TestToolbarModel* test_toolbar_model = new TestToolbarModel;
+ scoped_ptr<ToolbarModel> toolbar_model(test_toolbar_model);
+ test_toolbar_model->set_text(ASCIIToUTF16("http://www.google.com/"));
+ browser()->swap_toolbar_models(&toolbar_model);
OmniboxView* omnibox_view = NULL;
ASSERT_NO_FATAL_FAILURE(GetOmniboxView(&omnibox_view));
+ OmniboxEditModel* edit_model = omnibox_view->model();
+ ASSERT_NE(static_cast<OmniboxEditModel*>(NULL), edit_model);
+ edit_model->UpdatePermanentText();
+
const char* target_url = "http://www.google.com/calendar";
omnibox_view->SetUserText(ASCIIToUTF16(target_url));
- // Set permanent text thus making sure that omnibox treats 'google.com'
- // as URL (not as ordinary user input).
- OmniboxEditModel* edit_model = omnibox_view->model();
- ASSERT_NE(static_cast<OmniboxEditModel*>(NULL), edit_model);
- edit_model->UpdatePermanentText(ASCIIToUTF16("http://www.google.com/"));
-
// Location bar must have focus.
chrome::FocusLocationBar(browser());
ASSERT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_OMNIBOX));
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698