chrome/browser/ui/omnibox/omnibox_edit_unittest.cc - Issue 23804002: Make OmniboxEditModel::UpdatePermanentText() fetch the new text itself rather

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_unittest.cc

Issue 23804002: Make OmniboxEditModel::UpdatePermanentText() fetch the new text itself rather (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | chrome/browser/ui/omnibox/omnibox_view.cc » ('j') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_edit_unittest.cc

===================================================================

--- chrome/browser/ui/omnibox/omnibox_edit_unittest.cc (revision 220446)

+++ chrome/browser/ui/omnibox/omnibox_edit_unittest.cc (working copy)

@@ -192,7 +192,8 @@

OmniboxEditModel model(&view, &controller, &profile);

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(input); ++i) {

- model.UpdatePermanentText(ASCIIToUTF16(input[i].perm_text));

+ toolbar_model()->set_text(ASCIIToUTF16(input[i].perm_text));

+ model.UpdatePermanentText();

toolbar_model()->set_replace_search_url_with_search_terms(

input[i].extracted_search_terms);