Make OmniboxEditModel::UpdatePermanentText() fetch the new text itself rather

Make OmniboxEditModel::UpdatePermanentText() fetch the new text itself rather
than taking it as an arg.

The next change for Show URL will result in this function needing to muck with
the toolbar model and possibly re-fetch the text afterwards, so this change
prepares for that.

BUG=248287
TEST=none
R=msw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220653

[msw, 2013-08-30 16:12:15]

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1678: TestToolbarModel*
toolbar_model = new TestToolbarModel;
Remove |toolbar_model|, rename |toolbar_model_deleter| to |toolbar_model|.

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1725: TestToolbarModel*
toolbar_model = new TestToolbarModel;
ditto

[Peter Kasting, 2013-08-30 18:26:47]

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1678: TestToolbarModel*
toolbar_model = new TestToolbarModel;
On 2013/08/30 16:12:16, msw wrote:
> Remove |toolbar_model|, rename |toolbar_model_deleter| to |toolbar_model|.

I need a TestToolbarModel type to call set_text(), which doesn't exist on
ToolbarModel.

I could do something like this:

  scoped_ptr<ToolbarModel> toolbar_model(new TestToolbarModel());
  static_cast<TestToolbarModel*>(toolbar_model.get())->set_text(...);

...But I decided that was ugly compared to the current method; casting to
something you _just had_ seems lame.

So I'd rather leave it the current way.

[msw, 2013-08-30 18:32:26]

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
File chrome/browser/ui/omnibox/omnibox_view_browsertest.cc (right):

https://codereview.chromium.org/23804002/diff/25002/chrome/browser/ui/omnibox...
chrome/browser/ui/omnibox/omnibox_view_browsertest.cc:1678: TestToolbarModel*
toolbar_model = new TestToolbarModel;
On 2013/08/30 18:26:48, Peter Kasting wrote:
> On 2013/08/30 16:12:16, msw wrote:
> > Remove |toolbar_model|, rename |toolbar_model_deleter| to |toolbar_model|.
> 
> I need a TestToolbarModel type to call set_text(), which doesn't exist on
> ToolbarModel.
> 
> I could do something like this:
> 
>   scoped_ptr<ToolbarModel> toolbar_model(new TestToolbarModel());
>   static_cast<TestToolbarModel*>(toolbar_model.get())->set_text(...);
> 
> ...But I decided that was ugly compared to the current method; casting to
> something you _just had_ seems lame.
> 
> So I'd rather leave it the current way.

Ah, I didn't realize it was using test-specific API and I agree. Can you rename
|toolbar_model| to |test_toolbar_model| and then rename |toolbar_model_deleter|
to |toolbar_model|? 'Deleter' seem really odd.

[Peter Kasting, 2013-08-30 18:42:19]

On 2013/08/30 18:32:26, msw wrote:
> Ah, I didn't realize it was using test-specific API and I agree. Can you
rename
> |toolbar_model| to |test_toolbar_model| and then rename
|toolbar_model_deleter|
> to |toolbar_model|? 'Deleter' seem really odd.

OK.

[msw, 2013-08-30 20:06:57]

LGTM; thanks!

[Peter Kasting, 2013-08-30 20:54:30]

Committed patchset #5 manually as r220653 (presubmit successful).