Issue 2380373002: Do not build unicode_to_keysym.cc when use_x11 == 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2380373002: Do not build unicode_to_keysym.cc when use_x11 == 0 (Closed)

Created:
4 years, 2 months ago by Rahul Chaturvedi

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Do not build unicode_to_keysym.cc when use_x11 == 0 BUG=608832 Review-Url: https://codereview.chromium.org/1997533002 Cr-Commit-Position: refs/heads/master@{#395162} (cherry picked from commit 02dfd6d2723ed54559156a1b491c53dc596f898e) Committed: https://chromium.googlesource.com/chromium/src/+/622cd4c8344b3b4e4057d44bd4a1d94b4422399f

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
M	remoting/host/BUILD.gn	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	remoting/remoting_host.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/remoting_test.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Rahul Chaturvedi

4 years, 2 months ago (2016-09-30 18:34:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
622cd4c8344b3b4e4057d44bd4a1d94b4422399f.