Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: mojo/public/js/validation_unittests.js

Issue 2380303003: [Mojo] Make javascript enums extensible. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/js/validation_unittests.js
diff --git a/mojo/public/js/validation_unittests.js b/mojo/public/js/validation_unittests.js
index f2e3dadaf7bc2ad41ffcc2ec2c16970ea37b7f3c..7b1c173414ba7c0c46b43dc9348b23c89bf5c57b 100644
--- a/mojo/public/js/validation_unittests.js
+++ b/mojo/public/js/validation_unittests.js
@@ -227,8 +227,6 @@ define([
// because JS numbers are limited to 53 bits.
// TODO(yzshen) Skipping struct versioning tests (tests with "mthd11"
// in the name) because the feature is not supported in JS yet.
- // TODO(yzshen) Skipping enum validation tests (tests with "enum" in the
- // name) because the feature is not supported in JS yet. crbug.com/581390
// TODO(rudominer): Temporarily skipping 'no-such-method',
// 'invalid_request_flags', and 'invalid_response_flags' until additional
// logic in *RequestValidator and *ResponseValidator is ported from
@@ -237,7 +235,6 @@ define([
if (testFiles[i].indexOf("overflow") != -1 ||
testFiles[i].indexOf("mthd11") != -1 ||
testFiles[i].indexOf("conformance_mthd19") != -1 ||
- testFiles[i].indexOf("enum") != -1 ||
testFiles[i].indexOf("no_such_method") != -1 ||
testFiles[i].indexOf("invalid_request_flags") != -1 ||
testFiles[i].indexOf("invalid_response_flags") != -1) {
« no previous file with comments | « no previous file | mojo/public/js/validator.js » ('j') | mojo/public/tools/bindings/generators/mojom_js_generator.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698