Issue 23803007: Fix wraparound of deoptimization count in shared function info.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23803007: Fix wraparound of deoptimization count in shared function info.

Created:
7 years, 3 months ago by titzer

Modified:
7 years, 3 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix wraparound of deoptimization count in shared function info. BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -6 lines)			Patch
M	src/objects.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+14 lines, -2 lines	1 comment	Download
M	src/runtime-profiler.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

7 years, 3 months ago (2013-09-05 18:13:57 UTC) #2

lgtm with nit

https://codereview.chromium.org/23803007/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/23803007/diff/1/src/objects-inl.h#newcode4892
src/objects-inl.h:4892: deopt_count = (deopt_count + 1) & DeoptCountBits::kMax;
I guess this mask isn't necessary anymore.

Expand Messages | Collapse Messages