Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2449)

Unified Diff: android_webview/browser/aw_browser_context.cc

Issue 23803005: Fix threading issues in aw form database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address code review Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_browser_context.cc
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
index 9700645683e3a551ed056b8cae2a4e66a8bee5a0..f930c19316ea8a4c2f62f5fe10036df23826dc64 100644
--- a/android_webview/browser/aw_browser_context.cc
+++ b/android_webview/browser/aw_browser_context.cc
@@ -23,6 +23,8 @@
#include "content/public/browser/web_contents.h"
#include "net/url_request/url_request_context.h"
+using content::BrowserThread;
+
namespace android_webview {
namespace {
@@ -41,11 +43,11 @@ class AwResourceContext : public content::ResourceContext {
// content::ResourceContext implementation.
virtual net::HostResolver* GetHostResolver() OVERRIDE {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
return getter_->GetURLRequestContext()->host_resolver();
}
virtual net::URLRequestContext* GetRequestContext() OVERRIDE {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
return getter_->GetURLRequestContext();
}
virtual bool AllowMicAccess(const GURL& origin) OVERRIDE {
@@ -73,6 +75,9 @@ AwBrowserContext::AwBrowserContext(
user_pref_service_ready_(false) {
DCHECK(g_browser_context == NULL);
g_browser_context = this;
+
+ form_database_service_.reset(
+ new AwFormDatabaseService(context_storage_path_));
}
AwBrowserContext::~AwBrowserContext() {
@@ -146,10 +151,6 @@ AwQuotaManagerBridge* AwBrowserContext::GetQuotaManagerBridge() {
}
AwFormDatabaseService* AwBrowserContext::GetFormDatabaseService() {
- if (!form_database_service_) {
- form_database_service_.reset(
- new AwFormDatabaseService(context_storage_path_));
- }
return form_database_service_.get();
}
« no previous file with comments | « no previous file | android_webview/browser/aw_form_database_service.h » ('j') | android_webview/browser/aw_form_database_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698