Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: android_webview/browser/aw_form_database_service.h

Issue 23803005: Fix threading issues in aw form database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
6 #define ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_ 6 #define ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/synchronization/lock.h"
10 #include "base/synchronization/waitable_event.h" 11 #include "base/synchronization/waitable_event.h"
11 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h" 12 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
12 #include "components/webdata/common/web_data_service_consumer.h" 13 #include "components/webdata/common/web_data_service_consumer.h"
13 #include "components/webdata/common/web_database_service.h" 14 #include "components/webdata/common/web_database_service.h"
14 15
15 namespace android_webview { 16 namespace android_webview {
16 17
17 // Handles the database operations necessary to implement the autocomplete 18 // Handles the database operations necessary to implement the autocomplete
18 // functionality. This includes creating and initializing the components that 19 // functionality. This includes creating and initializing the components that
19 // handle the database backend, and providing a synchronous interface when 20 // handle the database backend, and providing a synchronous interface when
(...skipping 18 matching lines...) Expand all
38 39
39 // WebDataServiceConsumer implementation. 40 // WebDataServiceConsumer implementation.
40 virtual void OnWebDataServiceRequestDone( 41 virtual void OnWebDataServiceRequestDone(
41 WebDataServiceBase::Handle h, 42 WebDataServiceBase::Handle h,
42 const WDTypedResult* result) OVERRIDE; 43 const WDTypedResult* result) OVERRIDE;
43 44
44 private: 45 private:
45 // Cancels the currently pending WebDataService query, if there is one. 46 // Cancels the currently pending WebDataService query, if there is one.
46 void CancelPendingQuery(); 47 void CancelPendingQuery();
47 48
48 void HasFormDataImpl(); 49 void ClearFormDataLocked();
50 void HasFormDataLocked();
49 51
50 // Stores the query handle when an async database query is executed. 52 // Stores the query handle when an async database query is executed.
51 WebDataServiceBase::Handle pending_query_handle_; 53 WebDataServiceBase::Handle pending_query_handle_;
52 bool has_form_data_; 54 bool has_form_data_;
53 base::WaitableEvent completion_; 55 base::WaitableEvent completion_;
56 base::Lock lock_;
54 57
55 scoped_refptr<autofill::AutofillWebDataService> autofill_data_; 58 scoped_refptr<autofill::AutofillWebDataService> autofill_data_;
56 scoped_refptr<WebDatabaseService> web_database_; 59 scoped_refptr<WebDatabaseService> web_database_;
57 60
58 DISALLOW_COPY_AND_ASSIGN(AwFormDatabaseService); 61 DISALLOW_COPY_AND_ASSIGN(AwFormDatabaseService);
59 }; 62 };
60 63
61 } // namespace android_webview 64 } // namespace android_webview
62 65
63 #endif // ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_ 66 #endif // ANDROID_WEBVIEW_BROWSER_AW_FORM_DATABASE_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698