Adds LogDnsClient::NotifyWhenNotThrottled

components/certificate_transparency/log_dns_client.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/certificate_transparency/log_dns_client.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/format_macros.h"
 #include "base/location.h"
@@ skipping 390 matching lines @@
 }
 
 void LogDnsClient::OnDNSChanged() {
   UpdateDnsConfig();
 }
 
 void LogDnsClient::OnInitialDNSConfigRead() {
   UpdateDnsConfig();
 }
 
+void LogDnsClient::NotifyWhenNotThrottled(const base::Closure& callback) {
+  DCHECK(HasMaxConcurrentQueriesInProgress());
+  not_throttled_callbacks_.push_back(callback);
+}
+
 net::Error LogDnsClient::QueryAuditProof(base::StringPiece domain_for_log,
                                          base::StringPiece leaf_hash,
                                          uint64_t tree_size,
                                          const AuditProofCallback& callback) {
   if (domain_for_log.empty() || leaf_hash.size() != crypto::kSHA256Length) {
     return net::ERR_INVALID_ARGUMENT;
   }
 
   if (HasMaxConcurrentQueriesInProgress()) {
     return net::ERR_TEMPORARILY_THROTTLED;
@@ skipping 25 matching lines @@
   auto query_iterator =
       std::find_if(audit_proof_queries_.begin(), audit_proof_queries_.end(),
                    [query](const std::unique_ptr<AuditProofQuery>& p) {
                      return p.get() == query;
                    });
   DCHECK(query_iterator != audit_proof_queries_.end());
   audit_proof_queries_.erase(query_iterator);
 
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(callback, result, base::Passed(&proof)));
+
+  for (const base::Closure& callback : not_throttled_callbacks_) {
+    callback.Run();
+  }
+  not_throttled_callbacks_.clear();

[Ryan Sleevi, 2016/10/07 15:22:55]

Because the base::Callback could result in deletion of |this| (since it's a
callback and you have no guarantee over what the callback behaviour will be),
I'd just recommend the following

std::list<base::Closure> callbacks = std::move(not_throttled_callbacks_);
for (const auto& callback : callbacks) {
  callback.Run();
}

That is, force it into a stack temporary

[Rob Percival, 2016/10/20 12:43:13]

Done.

 }
 
 bool LogDnsClient::HasMaxConcurrentQueriesInProgress() const {
   return max_concurrent_queries_ != 0 &&
          audit_proof_queries_.size() >= max_concurrent_queries_;
 }
 
 void LogDnsClient::UpdateDnsConfig() {
   net::DnsConfig config;
   net::NetworkChangeNotifier::GetDnsConfig(&config);
   if (config.IsValid())
     dns_client_->SetConfig(config);
 }
 
 }  // namespace certificate_transparency