Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2380273003: Include more information when deserializing ProgramInfo (Closed)

Created:
4 years, 2 months ago by Harry Terkelsen
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include more information when deserializing ProgramInfo Also: * use durations instead of int in ProgramInfo * fix some strong mode errors * add a test for parsing from a real program R=sigmund@google.com Committed: https://github.com/dart-lang/dart2js_info/commit/c0556de36bf01a3c52404fcfde42d32fd64ca767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1914 lines, -28 lines) Patch
M bin/deferred_library_size.dart View 1 chunk +1 line, -1 line 0 comments Download
M bin/function_size_analysis.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M lib/info.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M lib/json_info_codec.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/hello_world/hello_world.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A test/hello_world/hello_world.js.info.json View 1 chunk +1869 lines, -0 lines 0 comments Download
M test/parse_test.dart View 1 chunk +19 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 2 months ago (2016-09-30 21:15:38 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 2 months ago (2016-09-30 22:13:32 UTC) #3
Harry Terkelsen
4 years, 2 months ago (2016-09-30 22:24:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0556de36bf01a3c52404fcfde42d32fd64ca767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698