third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp - Issue 2380273002: Added reply field to blink NotificationEvent (not yet piped through)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp

Issue 2380273002: Added reply field to blink NotificationEvent (not yet piped through) (Closed)

Patch Set: Add a test for default value of notificationevent.reply Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationEvent.h ('k') | third_party/WebKit/Source/modules/notifications/NotificationEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp b/third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp

index e93968ccbb0b119173d7a93923a00b1fb0d24994..9aabfc6fc674b74a70e411c4b321da131b15daef 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationEvent.cpp

@@ -12,6 +12,7 @@ namespace blink {

NotificationEvent::NotificationEvent(const AtomicString& type, const NotificationEventInit& initializer)

: ExtendableEvent(type, initializer)

, m_action(initializer.action())

+ , m_reply(initializer.reply())

{

if (initializer.hasNotification())

m_notification = initializer.notification();

@@ -20,6 +21,7 @@ NotificationEvent::NotificationEvent(const AtomicString& type, const Notificatio

NotificationEvent::NotificationEvent(const AtomicString& type, const NotificationEventInit& initializer, WaitUntilObserver* observer)

: ExtendableEvent(type, initializer, observer)

, m_action(initializer.action())

+ , m_reply(initializer.reply())

{

if (initializer.hasNotification())

m_notification = initializer.notification();