third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js - Issue 2380273002: Added reply field to blink NotificationEvent (not yet piped through)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

Issue 2380273002: Added reply field to blink NotificationEvent (not yet piped through) (Closed)

Patch Set: Add a test for default value of notificationevent.reply Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js b/third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

index 7ed607eebcddbffd7c6bbaa447b810a3faefab49..400f065fc2886a0c73a131152cc14484adaf22e7 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

@@ -30,10 +30,12 @@ function runTest(notification) {

assert_equals(event.bubbles, false);

assert_equals(event.notification, notification);

assert_equals(event.action, '');

+ assert_equals(event.reply, '');

assert_inherits(event, 'waitUntil');

const customEvent = new NotificationEvent('NotificationEvent', {

notification: notification,

+ reply: 'my reply',

bubbles: true,

cancelable: true });

@@ -41,6 +43,7 @@ function runTest(notification) {

assert_equals(customEvent.cancelable, true);

assert_equals(customEvent.bubbles, true);

assert_equals(customEvent.notification, notification);

+ assert_equals(customEvent.reply, 'my reply');

} catch (e) {

result.success = false;

result.message = e.message + '\n' + e.stack;