third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl - Issue 2380273002: Added reply field to blink NotificationEvent (not yet piped through)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

Issue 2380273002: Added reply field to blink NotificationEvent (not yet piped through) (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/notifications/NotificationEvent.idl ('K') | « third_party/WebKit/Source/modules/notifications/NotificationEvent.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://notifications.spec.whatwg.org/#notificationevent	5 // https://notifications.spec.whatwg.org/#notificationevent

6	6

7 dictionary NotificationEventInit : ExtendableEventInit {	7 dictionary NotificationEventInit : ExtendableEventInit {

8 required Notification notification;	8 required Notification notification;

9 DOMString action = "";	9 DOMString reply = "";

	10 DOMString action = null;
	Peter Beverloo 2016/09/30 11:10:22 You're changing the default value from `action` to You're changing the default value from `action` to NULL, and add `reply` as an empty string. It seems to me like defaulting both to empty strings is the way to go, following the spec? (Or do you think NULL as the default value would make more sense?) awdf 2016/09/30 12:31:42 oops! I meant to set reply = null, so that a delib Show quoted text On 2016/09/30 11:10:22, Peter Beverloo wrote: > You're changing the default value from `action` to NULL, and add `reply` as an > empty string. It seems to me like defaulting both to empty strings is the way to > go, following the spec? > > (Or do you think NULL as the default value would make more sense?) oops! I meant to set reply = null, so that a deliberately empty reply could be distinguished. But given the developer can check if the feature is enabled by the presence of the field at all, there seems no point in distinguishing empty string from null in this case, so I'll change it to an empty string, like with action.
10 };	11 };

OLD	NEW