Source/core/page/EventHandler.cpp - Issue 238023004: Focusing iframe window should trigger blur event for oldframe's focused element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 238023004: Focusing iframe window should trigger blur event for oldframe's focused element (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/frames/frame-focus-send-blur-expected.txt ('k') | Source/core/page/FocusController.h » ('j') | Source/core/page/FocusController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 1fd074f6935f5f4302910f7571328a41826fd23b..77b404a16e5ed77b246a6ba22dcfcbbb60e90fc5 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -4033,7 +4033,7 @@ void EventHandler::focusDocumentView()

Page* page = m_frame->page();

if (!page)

return;

- page->focusController().setFocusedFrame(m_frame);

tkent 2014/04/23 02:23:31 Can you improve FocusController::setFocusedFrame i

gnana 2014/04/23 12:21:51 i tried improve in setfocusedframe. But setfocused

+ page->focusController().focusDocumentView(m_frame);

}

unsigned EventHandler::accessKeyModifiers()

« no previous file with comments | « LayoutTests/fast/frames/frame-focus-send-blur-expected.txt ('k') | Source/core/page/FocusController.h » ('j') | Source/core/page/FocusController.cpp » ('J')