Focusing iframe window should trigger blur event for oldframe's focused element

Focusing iframe window should trigger blur event for oldframe's focused element

when inactive frame is focused, in EventHandler::focusDocumentView sending a blur event to the old frame focusedelement and sending focus event for the new frame focused element.
This makes behaviour consistent with IE and firefox.

BUG=361746
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172437

[gnana, 2014-04-16 14:33:57]

Please have a look.

[gnana, 2014-04-22 06:06:44]

The CQ bit was checked by gnanasekar.s@samsung.com

[gnana, 2014-04-22 06:06:45]

The CQ bit was unchecked by gnanasekar.s@samsung.com

[gnana, 2014-04-22 08:32:19]

Please have a look.

[gnana, 2014-04-22 08:32:19]

Please have a look.

[gnana, 2014-04-22 08:32:19]

Please have a look.

[tkent, 2014-04-23 02:23:30]

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (left):

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:4036:
page->focusController().setFocusedFrame(m_frame);
Can you improve FocusController::setFocusedFrame instead of introducing
focusDocumentView?

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/FocusC...
File Source/core/page/FocusController.cpp (right):

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/FocusC...
Source/core/page/FocusController.cpp:276: focusedElement->dispatchBlurEvent(0);
We need to dispatch 'focusout' and 'DOMFocusOut' events too.

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/FocusC...
Source/core/page/FocusController.cpp:284: focusedElement->dispatchFocusEvent(0,
FocusTypePage);
We need to dispatch 'focusin' and 'DOMFocusIn' events too.

[gnana, 2014-04-23 12:21:50]

Please have a look

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/EventH...
File Source/core/page/EventHandler.cpp (left):

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/EventH...
Source/core/page/EventHandler.cpp:4036:
page->focusController().setFocusedFrame(m_frame);
On 2014/04/23 02:23:31, tkent wrote:
> Can you improve FocusController::setFocusedFrame instead of introducing
> focusDocumentView?
i tried improve in setfocusedframe. But setfocusedframe is also called in other
places. so i can see multiple blur/focusout events are dispatched in other
usecases.
I think its better to have a seperate api.

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/FocusC...
File Source/core/page/FocusController.cpp (right):

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/FocusC...
Source/core/page/FocusController.cpp:276: focusedElement->dispatchBlurEvent(0);
On 2014/04/23 02:23:31, tkent wrote:
> We need to dispatch 'focusout' and 'DOMFocusOut' events too.

Done.

https://codereview.chromium.org/238023004/diff/110001/Source/core/page/FocusC...
Source/core/page/FocusController.cpp:284: focusedElement->dispatchFocusEvent(0,
FocusTypePage);
On 2014/04/23 02:23:31, tkent wrote:
> We need to dispatch 'focusin' and 'DOMFocusIn' events too.

Done.

[tkent, 2014-04-24 00:38:45]

lgtm

[commit-bot: I haz the power, 2014-04-24 00:38:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/238023004/150001

[commit-bot: I haz the power, 2014-04-24 01:52:44]

Change committed as 172437