cros: Fix API 'add' password and complete auth racing

cros: Fix API 'add' password and complete auth racing

Authenticator.maybeCompleteAuth_ is attempted on webview.loadcommit
and webview.request.onCompleted events. Auth is completed when all
info is collected. Gaia uses credential passing API to send back the
password. This, however, is not bound to the two events. If the
two events happen before the 'add' API calls through, auth never
gets completed. This CL fixes the racing by adding maybeCompleteAuth_
on the API 'add' call.

BUG=650543
TEST=Existing login tests should pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4caa576572fa920a66f1e9449daa9f41ce80b76f
Cr-Commit-Position: refs/heads/master@{#422130}

[xiyuan, 2016-09-29 22:33:38]

Description was changed from

==========
cros: Fix API 'add' password and complete auth racing

Authenticator.maybeCompleteAuth_ is attempted on webview.loadcommit
and webview.request.onCompleted events. Auth is completed when all
info is collected. Gaia uses credential passing API to send back the
password. This, however, is not bound to the two events. If the
two events happen before the 'add' API calls through, auth never
gets completed. This CL fixes the racing by adding maybeCompleteAuth_
on the API 'add' call.

BUG=650543
TEST=Existing login tests should pass.
==========

to

==========
cros: Fix API 'add' password and complete auth racing

Authenticator.maybeCompleteAuth_ is attempted on webview.loadcommit
and webview.request.onCompleted events. Auth is completed when all
info is collected. Gaia uses credential passing API to send back the
password. This, however, is not bound to the two events. If the
two events happen before the 'add' API calls through, auth never
gets completed. This CL fixes the racing by adding maybeCompleteAuth_
on the API 'add' call.

BUG=650543
TEST=Existing login tests should pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xiyuan, 2016-09-29 22:34:44]

xiyuan@chromium.org changed reviewers:
+ achuith@chromium.org

[xiyuan, 2016-09-29 22:35:11]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:35:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2016-09-29 22:36:06]

lgtm, thanks!

[commit-bot: I haz the power, 2016-09-29 23:33:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:33:56]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-09-30 16:29:47]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2016-09-30 16:30:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:36:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-30 16:38:40]

Description was changed from

==========
cros: Fix API 'add' password and complete auth racing

Authenticator.maybeCompleteAuth_ is attempted on webview.loadcommit
and webview.request.onCompleted events. Auth is completed when all
info is collected. Gaia uses credential passing API to send back the
password. This, however, is not bound to the two events. If the
two events happen before the 'add' API calls through, auth never
gets completed. This CL fixes the racing by adding maybeCompleteAuth_
on the API 'add' call.

BUG=650543
TEST=Existing login tests should pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Fix API 'add' password and complete auth racing

Authenticator.maybeCompleteAuth_ is attempted on webview.loadcommit
and webview.request.onCompleted events. Auth is completed when all
info is collected. Gaia uses credential passing API to send back the
password. This, however, is not bound to the two events. If the
two events happen before the 'add' API calls through, auth never
gets completed. This CL fixes the racing by adding maybeCompleteAuth_
on the API 'add' call.

BUG=650543
TEST=Existing login tests should pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4caa576572fa920a66f1e9449daa9f41ce80b76f
Cr-Commit-Position: refs/heads/master@{#422130}
==========

[commit-bot: I haz the power, 2016-09-30 16:38:41]

Patchset 1 (id:??) landed as
https://crrev.com/4caa576572fa920a66f1e9449daa9f41ce80b76f
Cr-Commit-Position: refs/heads/master@{#422130}