[Offline Pages] SnapshotController support for delay after onLoadCompleted and also parameterized c…

components/offline_pages/snapshot_controller_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/snapshot_controller.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/test/test_mock_time_task_runner.h"
@@ skipping 59 matching lines @@
 
 void SnapshotControllerTest::PumpLoop() {
   task_runner_->RunUntilIdle();
 }
 
 void SnapshotControllerTest::FastForwardBy(base::TimeDelta delta) {
   task_runner_->FastForwardBy(delta);
 }
 
 TEST_F(SnapshotControllerTest, OnLoad) {
-  // Onload should make snapshot right away.
-  EXPECT_EQ(0, snapshot_count());
+  // Onload should make snapshot after its delay.
   controller()->DocumentOnLoadCompletedInMainFrame();
   PumpLoop();
+  EXPECT_EQ(0, snapshot_count());
+  FastForwardBy(base::TimeDelta::FromMilliseconds(
+      controller()->GetDelayAfterDocumentOnLoadCompletedForTest()));
   EXPECT_EQ(1, snapshot_count());
 }
 
 TEST_F(SnapshotControllerTest, OnDocumentAvailable) {
   EXPECT_GT(controller()->GetDelayAfterDocumentAvailableForTest(), 0UL);
   // OnDOM should make snapshot after a delay.
   controller()->DocumentAvailableInMainFrame();
   PumpLoop();
   EXPECT_EQ(0, snapshot_count());
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   EXPECT_EQ(1, snapshot_count());
 }
 
 TEST_F(SnapshotControllerTest, OnLoadSnapshotIsTheLastOne) {
+  // This test assumes DocumentAvailable delay is longer than OnLoadCompleted.
+  EXPECT_GT(controller()->GetDelayAfterDocumentAvailableForTest(),
+            controller()->GetDelayAfterDocumentOnLoadCompletedForTest());
   // OnDOM should make snapshot after a delay.
   controller()->DocumentAvailableInMainFrame();
   PumpLoop();
   EXPECT_EQ(0, snapshot_count());
-  // This should start snapshot immediately.
   controller()->DocumentOnLoadCompletedInMainFrame();
+  // Advance time to OnLoadCompleted delay to trigger snapshot.
+  FastForwardBy(base::TimeDelta::FromMilliseconds(
+      controller()->GetDelayAfterDocumentOnLoadCompletedForTest()));
   EXPECT_EQ(1, snapshot_count());
   // Report that snapshot is completed.
   controller()->PendingSnapshotCompleted();
   // Even though previous snapshot is completed, new one should not start
-  // when this delay expires.
+  // when this DocumentAvailable delay expires.
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   EXPECT_EQ(1, snapshot_count());
 }
 
 TEST_F(SnapshotControllerTest, OnLoadSnapshotAfterLongDelay) {
   // OnDOM should make snapshot after a delay.
   controller()->DocumentAvailableInMainFrame();
   PumpLoop();
   EXPECT_EQ(0, snapshot_count());
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   EXPECT_EQ(1, snapshot_count());
   // Report that snapshot is completed.
   controller()->PendingSnapshotCompleted();
-  // This should start snapshot immediately.
+  // OnLoad should make 2nd snapshot after its delay.
   controller()->DocumentOnLoadCompletedInMainFrame();
+  FastForwardBy(base::TimeDelta::FromMilliseconds(
+      controller()->GetDelayAfterDocumentOnLoadCompletedForTest()));
   EXPECT_EQ(2, snapshot_count());
 }
 
 TEST_F(SnapshotControllerTest, Stop) {
   // OnDOM should make snapshot after a delay.
   controller()->DocumentAvailableInMainFrame();
   PumpLoop();
   EXPECT_EQ(0, snapshot_count());
   controller()->Stop();
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   // Should not start snapshots
   EXPECT_EQ(0, snapshot_count());
   // Also should not start snapshot.
   controller()->DocumentOnLoadCompletedInMainFrame();
   EXPECT_EQ(0, snapshot_count());
 }
 
 TEST_F(SnapshotControllerTest, ClientReset) {
   controller()->DocumentAvailableInMainFrame();
 
   controller()->Reset();
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   // No snapshot since session was reset.
   EXPECT_EQ(0, snapshot_count());
   controller()->DocumentOnLoadCompletedInMainFrame();
+  FastForwardBy(base::TimeDelta::FromMilliseconds(
+      controller()->GetDelayAfterDocumentOnLoadCompletedForTest()));
   EXPECT_EQ(1, snapshot_count());
 
   controller()->Reset();
   controller()->DocumentAvailableInMainFrame();
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   // No snapshot since session was reset.
   EXPECT_EQ(2, snapshot_count());
 }
 
 // This simulated a Reset while there is ongoing snapshot, which is reported
 // as done later. That reporting should have no effect nor crash.
 TEST_F(SnapshotControllerTest, ClientResetWhileSnapshotting) {
   controller()->DocumentOnLoadCompletedInMainFrame();
+  FastForwardBy(base::TimeDelta::FromMilliseconds(
+      controller()->GetDelayAfterDocumentOnLoadCompletedForTest()));
   EXPECT_EQ(1, snapshot_count());
   // This normally happens when navigation starts.
   controller()->Reset();
   controller()->PendingSnapshotCompleted();
   // Next snapshot should be initiated when new document is loaded.
   controller()->DocumentAvailableInMainFrame();
   FastForwardBy(base::TimeDelta::FromMilliseconds(
       controller()->GetDelayAfterDocumentAvailableForTest()));
   // No snapshot since session was reset.
   EXPECT_EQ(2, snapshot_count());
 }
 
 }  // namespace offline_pages