Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2380073005: Support group and wrapping navigation. (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support group and wrapping navigation. Group nav (paragraph nav) is bound to Search+Ctrl+up/down. Define groups as loosely as possible and don't sync so nav remains as high up as possible for role/predicate matches to occur. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=643840 Committed: https://crrev.com/bc392fc2e7ca0702a06bc188d09b8dd8db2f07ba Cr-Commit-Position: refs/heads/master@{#422864}

Patch Set 1 : m #

Patch Set 2 : Landmarks are too busy... #

Patch Set 3 : Update test expectations. #

Messages

Total messages: 17 (10 generated)
David Tseng
4 years, 2 months ago (2016-09-30 22:37:57 UTC) #5
dmazzoni
lgtm
4 years, 2 months ago (2016-10-03 22:24:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380073005/40001
4 years, 2 months ago (2016-10-03 22:38:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/246303)
4 years, 2 months ago (2016-10-03 23:47:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380073005/60001
4 years, 2 months ago (2016-10-04 17:23:05 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-04 18:35:52 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:37:16 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bc392fc2e7ca0702a06bc188d09b8dd8db2f07ba
Cr-Commit-Position: refs/heads/master@{#422864}

Powered by Google App Engine
This is Rietveld 408576698