Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2380073002: [stubs] Fix label names in StringCharCodeAt (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix label names in StringCharCodeAt The label names were reversed - an external string is a short external string if (instance_type | kShortExternalStringMask) != 0. R=ishell@chromium.org BUG= Committed: https://crrev.com/6a2169c00d65e22452936fbcce3ce97763381165 Cr-Commit-Position: refs/heads/master@{#39880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/code-stub-assembler.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jgruber
4 years, 2 months ago (2016-09-29 14:54:53 UTC) #3
Igor Sheludko
lgtm
4 years, 2 months ago (2016-09-29 14:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380073002/1
4 years, 2 months ago (2016-09-29 15:50:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 15:53:45 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:54:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a2169c00d65e22452936fbcce3ce97763381165
Cr-Commit-Position: refs/heads/master@{#39880}

Powered by Google App Engine
This is Rietveld 408576698