Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2380053002: aw: Change telemetry traces to collect better startup time stats. (Closed)

Created:
4 years, 2 months ago by Tobias Sargeant
Modified:
4 years, 2 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Change telemetry traces to collect better startup time stats. 1) Time new WebView + setContentView - this tests how an app that has a WebView in its layout will be affected. 2) Time the full time from new WebView to onPageFinished. This allows us to know if we regress something that happens asynchronously on startup that blocks URL loading. BUG= Committed: https://crrev.com/c73f1c265e7a8e61e280a0dfa53f826f08b548c4 Cr-Commit-Position: refs/heads/master@{#422798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java View 3 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Tobias Sargeant
4 years, 2 months ago (2016-09-29 14:41:01 UTC) #2
Torne
LGTM. I assume we need to update something to track the new trace tag, and ...
4 years, 2 months ago (2016-09-29 15:29:05 UTC) #3
perezju
rs-lgtm, but keep alexandermont in the loop. Will this need a change on the metrics ...
4 years, 2 months ago (2016-09-29 15:38:47 UTC) #5
Tobias Sargeant
On 2016/09/29 15:38:47, perezju wrote: > rs-lgtm, but keep alexandermont in the loop. Will this ...
4 years, 2 months ago (2016-09-29 15:40:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380053002/1
4 years, 2 months ago (2016-10-04 15:01:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 15:11:09 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 15:13:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c73f1c265e7a8e61e280a0dfa53f826f08b548c4
Cr-Commit-Position: refs/heads/master@{#422798}

Powered by Google App Engine
This is Rietveld 408576698