Chromium Code Reviews Chromium Code Reviews
Issue 238005:
Invert the new incognito tab Spyman orientation and location for RTL.... (Closed)
Base URL: svn://chrome-svn/chrome/trunk/src/| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html i18n-values="dir:textdirection;bookmarkbarattached:bookmarkbarattached"> | 2 <html i18n-values="dir:textdirection;bookmarkbarattached:bookmarkbarattached"> |
| 3 <head> | 3 <head> |
| 4 <title i18n-content="title"></title> | 4 <title i18n-content="title"></title> |
| 5 <style> | 5 <style> |
| 6 body { | 6 body { |
| 7 margin:10px 8px 10px 8px; | 7 margin:10px 8px 10px 8px; |
| 8 } | 8 } |
| 9 .icon { | 9 html[dir="ltr"] .icon { |
| 10 float:right; | 10 float:right; |
| 11 margin:0px 6px 0px 3px; | 11 margin:0 6px 0 3px; |
| 12 -webkit-transform: scale(-1, 1); | |
|
arv (Not doing code reviews)
2009/09/25 03:15:30
Isn't the flipping supposed to be done in rtl?
Evan Stade
2009/09/25 03:57:34
This part is a change to LTR. See the screenshots,
| |
| 13 } | |
| 14 html[dir="rtl"] .icon { | |
| 15 float:left; | |
| 16 margin:0 3px 0 6px; | |
| 12 } | 17 } |
| 13 .content { | 18 .content { |
| 14 -webkit-border-radius: 5px 5px; | 19 -webkit-border-radius: 5px 5px; |
| 15 background-color:#eee; | 20 background-color:#eee; |
| 16 color:black; | 21 color:black; |
| 17 padding:10px 10px 10px 10px; | 22 padding:10px 10px 10px 10px; |
| 18 max-width:600px; | 23 max-width:600px; |
| 19 margin-left:auto; | 24 margin-left:auto; |
| 20 margin-right:auto; | 25 margin-right:auto; |
| 21 } | 26 } |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 41 | 46 |
| 42 function bookmarkBarAttached() { | 47 function bookmarkBarAttached() { |
| 43 document.documentElement.setAttribute("bookmarkbarattached", "true"); | 48 document.documentElement.setAttribute("bookmarkbarattached", "true"); |
| 44 } | 49 } |
| 45 | 50 |
| 46 function bookmarkBarDetached() { | 51 function bookmarkBarDetached() { |
| 47 document.documentElement.setAttribute("bookmarkbarattached", "false"); | 52 document.documentElement.setAttribute("bookmarkbarattached", "false"); |
| 48 } | 53 } |
| 49 </script> | 54 </script> |
| 50 </html> | 55 </html> |
| OLD | NEW |
