Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 23800005: Refactoring only: Make it clear that MOD is special. (Closed)

Created:
7 years, 3 months ago by Sven Panne
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Refactoring only: Make it clear that MOD is special. LArithmeticD should really be 5 different instructions... :-/ R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16745

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 3 months ago (2013-09-17 06:46:14 UTC) #1
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-17 07:18:56 UTC) #2
Sven Panne
7 years, 3 months ago (2013-09-17 07:29:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698